feat(DataTable): adjust expandable row striping #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expandable rows will now always match the stripe state of the row that toggles them. This fix is related to carbon-react#66 and is required to allow that fix to work properly.
|
👍 ✅ |
hellobrian
approved these changes
Jun 28, 2017
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
* fixed syntax issues in ModalStory, added id for disabled Select component in SelectStory * removed unneeded true value
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 8, 2019
* feat: added fluid spacing token * docs: updated demo with fluid spacing * feat: added grid--full-width modifier * docs: updated demos to reflect new changes to grid
designertyler
pushed a commit
to designertyler/carbon
that referenced
this pull request
Oct 14, 2019
…/shixie-FAQ-3col-layout-guide doc(FAQ): guidance to layout 3 column content on 2x grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fix is related to carbon-design-system/carbon-components-react#66 and is required to allow that fix to work properly.
Expandable rows will now always match the stripe state of the row that toggles them.
Changed
Adjusted sibling element selector for table rows and expanded table rows so that an expanded table row will always match the background color of the preceding table row.
Testing / Reviewing
Create a data table with expandable rows and verify that the expandable row inherits the background color of the preceding table row without any added classes.