Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text flows outside modal window #187

Closed
ghost opened this issue Jun 19, 2017 · 2 comments · Fixed by #190
Closed

Text flows outside modal window #187

ghost opened this issue Jun 19, 2017 · 2 comments · Fixed by #190

Comments

@ghost
Copy link

ghost commented Jun 19, 2017

What was the reasoning behind removing the overflow-y on the modal content in this commit? It caused a regression in my project.

Commit: 2612b2d#diff-d662c14c5dcd7e4b41028bf60b9bc77bL94

For example:
screen shot 2017-06-19 at 2 10 30 pm
@hellobrian hellobrian self-assigned this Jun 19, 2017
@hellobrian
Copy link
Contributor

Sorry about this regression, at the time it looked like overflow-y: auto wasn't needed and was removed but I didn't resize the browser drastically enough to see it was preventing that text flow from happening. I'll have a patch out really soon.

hellobrian pushed a commit to hellobrian/carbon-components that referenced this issue Jun 19, 2017
fix(modal.scss): re-add overflow-y
d7090e0 
fixes carbon-design-system#187

Needed for modal's content when the modal's viewport window is drastically short.
@hellobrian hellobrian mentioned this issue Jun 19, 2017
Merged
hellobrian added a commit that referenced this issue Jun 19, 2017
@hellobrian
fix(modal.scss): re-add overflow-y (#190)
a5374b2 
fixes #187

Needed for modal's content when the modal's viewport window is drastically short.
@hellobrian
Copy link
Contributor

Merged the fix. Should be available in v7.10.3 once master branch is done with Travis CI build

joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@reicruz
update stories in storybook to display API info (carbon-design-system…
a04eae8 
…#187) (carbon-design-system#203)

* update stories in storybook to display API info (carbon-design-system#187)

TextArea

TextInput

Tag

Select

SecondaryButton

Search

RadioButton

RadioButtonGroup

PrimaryButton

NumberInput

Small changes

Notification

Fix typo

Icon

FileUploader

DangerButton

Checkbox

Fix typos

ButtonSet

AppContainer

Tabs

OverflowMenu

ModalWrapper

Modal

Loading

Dropdown

ContentSwitcher

Cards

* remove ControlledDropdown class
joshblack pushed a commit to joshblack/carbon that referenced this issue May 8, 2019
@conradennis @joshblack
feat(icons): add new icons (carbon-design-system#187)
8b31150
designertyler pushed a commit to designertyler/carbon that referenced this issue Oct 14, 2019
@alisonjoseph
Merge pull request carbon-design-system#187 from carbon-design-system…
ba0a68e 
…/alisonjoseph-patch-4

chore: update deploy.yml to use macos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modal.scss): re-add overflow-y hellobrian/carbon-components
1 participant
@hellobrian