feat: Add spacing variables to file-uploader, checkbox, file-uploader, form, number-input, radio, select, text-area & text-input #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudoh
reviewed
Jan 19, 2018
| @@ -28,14 +29,13 @@ | |||
| @include typescale('zeta'); | |||
| @include line-height('body'); | |||
| color: $text-02; | |||
| margin-top: 0.25rem; | |||
There was a problem hiding this comment.
I'm kind of scratching the surface, but - Is removal of this line intentional?
There was a problem hiding this comment.
Yep, it’s intentional, the spacing on this component was updated, I can link the issue with the spec from Anna later.
There was a problem hiding this comment.
That's fine, as long as it's intentional I'm okay with merging!
marijohannessen
approved these changes
Jan 19, 2018
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
* refactor(checkbox): update checkbox to 7.x * fix(checkbox): update checkbox story to use fieldset * fix(a11y): update a11y test for checkbox
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…tests (carbon-design-system#514) * fix(OrderSummary): Add aria-labelledby, missing attributes fail A11Y tests, resolves carbon-design-system#513 * fix(OrderSummary): make id random to avoid duplication, resolves carbon-design-system#513 * fix(OrderSummary): default props are static, put them as default values
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 8, 2019
feat(icons) add /icons/master/ui-icon-master.ai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file-uploader
checkbox
form
number-input
radio button
select
text-area
text-input