fix(toolbar): resolve toolbar icon size issue #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, committed some extra things. |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…arbon-design-system#239) * fix(dropdown): added selectedText prop to the list to avoid warning * fix(dropdown): removed text from order summary story
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
May 8, 2019
* refactor(colors): move tokens out of colors package * feat(themes): add themes package * docs: run doctoc and update colors guide * chore: run sync * chore(project): update offline mirror * chore(project): add scss to gitignore in themes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ideal scenario would be tag the parent with a new class and expand the width, but that would require any consumers to update that and I guess that'd be a breaking change.