Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: Dropdown uses link rather than button as part of it's template #512

Closed
richardpilot opened this issue Jan 18, 2018 · 4 comments
Closed

a11y: Dropdown uses link rather than button as part of it's template #512

richardpilot opened this issue Jan 18, 2018 · 4 comments

Comments

@richardpilot
Copy link
Contributor

We've just moved to using Carbon for our UI and this was picked up by our accessibility tests that look for links where they shouldn't be.

Confirmed by the example, each option for the dropdown uses a link rather than a button
http://carbondesignsystem.com/components/dropdown/code

Given it's best practice to only use link as navigational elements rather than functional / form elements, can this be changed to be a button (we have now done so for our templates)
@tw15egan
Copy link
Contributor

tw15egan commented Jan 18, 2018 •
edited
Loading

I'll let the @carbon-design-system/design part of the team weigh in regarding the UX, but I believe the dropdown is supposed to be used for navigation, while the select component is the traditional form element.

We can update on our end if a button would be more suitable, but if anyone is currently using this component for navigation it will break them. Could we perhaps add an aria role or label for a11y enhancements?

@bsonefeld
Copy link
Contributor

@CptPilot , could you post a screenshot of what your use case looks like when using the Dropdown?

@richardpilot
Copy link
Contributor Author

Thanks for the pointer @tw15egan . Everyone had been referring to it as a dropdown in our design meetings that I hadn't spotted there was a Select component that meets our needs exactly. Apologies for the confusion, completely my fault. Closing.

@tw15egan
Copy link
Contributor

Happy to help 🙂

joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@tw15egan
refactor(text-input): update text-input to 7.x (carbon-design-system#512
8262e57 
)

* refactor(text-input): update text-input to 7.x

* refactor(text-input): wrap input in bx--form-item
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@greenkeeper @marijohannessen
Update lint-staged to the latest version 🚀 (carbon-design-system#512)
f95798a 
* chore(package): update lint-staged to version 6.0.1

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile
joshblack pushed a commit to joshblack/carbon that referenced this issue May 8, 2019
@jeanservaas @joshblack
feat(type): add new type tokens for productive and expressive (carbon…
9020b75 
…-design-system#512)

* Update type tokens

* chore(type): sync changes to sass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marijohannessen @bsonefeld @tw15egan @richardpilot