extract-jdbc: refactor constants #44482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 20, 2024 16:54
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Aug 21, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
postamar
changed the base branch from
postamar_gt_08-20-bulk-cdk_refactor_tests
to
master
|
/approve-and-merge reason="nobody else understands this code yet, nobody else uses it yet" |
|
This looks fine! |
octavia-approvington
approved these changes
Aug 21, 2024
octavia-approvington
deleted the
postamar_gt_08-20-extract-jdbc_refactor_constants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, we can't stuff whatever we want in a
metadata.yamlfile, or airbyte-ci will complain. This means that theDefaultJdbcSharedStateconstants need to be defined in anapplication.ymlfile (the Micronaut default). This PR also cleans upDefaultJdbcSharedStateconstants definition and makes it injectable