extract-jdbc: add and adopt JdbcSharedState and JdbcStreamState #44455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Aug 20, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 20, 2024
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_replace_airbytestreamdecorator_with_airbytestreamfactory
branch
from
a9194ab to
c393d61
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_add_and_adopt_jdbcsharedstate_and_jdbcstreamstate
branch
from
67b6878 to
5e5abaf
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_replace_airbytestreamdecorator_with_airbytestreamfactory
branch
from
c393d61 to
2d31ee8
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_add_and_adopt_jdbcsharedstate_and_jdbcstreamstate
branch
from
5e5abaf to
0c9eaec
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_replace_airbytestreamdecorator_with_airbytestreamfactory
branch
from
2d31ee8 to
371f7fa
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_add_and_adopt_jdbcsharedstate_and_jdbcstreamstate
branch
from
0c9eaec to
596a7b5
Compare
|
Closing because I'm merging the top of the stack #44482 into master using slash-approve-and-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #44403
This PR contains very little if no functional changes.
This PR introduces a
JdbcSharedStateMicronaut singleton and its friendJdbcStreamStatewhich eventually will replaceStreamReadContextin a downstream PR. The fetchSize and row byte size estimators now depend on this shared state singleton.This PR also replaces
StreamStateJsonValuewith an otherwise equivalentDefaultJdbcStreamStateValueclass.Some tests are moved around a bit. Notably, there now exist tests in extract-jdbc.
Informs airbytehq/airbyte-internal-issues#9093