bulk-cdk-core-extract: replace AirbyteStreamDecorator with AirbyteStreamFactory #44454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Aug 20, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 20, 2024
This was referenced Aug 20, 2024
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_rewrite_commentary_for_metadataquerier
branch
from
6390f94 to
bb3ea8e
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_replace_airbytestreamdecorator_with_airbytestreamfactory
branch
from
a9194ab to
c393d61
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_rewrite_commentary_for_metadataquerier
branch
from
bb3ea8e to
fa4ccf4
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_replace_airbytestreamdecorator_with_airbytestreamfactory
branch
from
c393d61 to
2d31ee8
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_rewrite_commentary_for_metadataquerier
branch
from
fa4ccf4 to
53e69bb
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk-core-extract_replace_airbytestreamdecorator_with_airbytestreamfactory
branch
from
2d31ee8 to
371f7fa
Compare
|
Closing because I'm merging the top of the stack #44482 into master using slash-approve-and-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current DiscoverOperation is overfitted to SQL database schemas and takes a bunch of unpleasant shortcuts which won't age well. This PR fixes this by changing the DiscoverOperation implementation, specifically around the MetadataQuerier and AirbyteStreamDecorator interfaces. I made too many simplifying assumptions when I first wrote these. I now push more logic down into the new AirbyteStreamFactory interface implementations.
Informs airbytehq/airbyte-internal-issues#9093