extract-jdbc: rename PartitionsCreator and PartitionReader impls #44457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Aug 20, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 20, 2024
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_refactor_partitionreader_and_partitionscreator_impls
branch
from
5904a00 to
6fdccb8
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_rename_partitionscreator_and_partitionreader_impls
branch
from
456b7b0 to
e82f2fe
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_refactor_partitionreader_and_partitionscreator_impls
branch
from
6fdccb8 to
1df0476
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_rename_partitionscreator_and_partitionreader_impls
branch
from
e82f2fe to
f3f5fb0
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_refactor_partitionreader_and_partitionscreator_impls
branch
from
1df0476 to
f0fbc36
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_rename_partitionscreator_and_partitionreader_impls
branch
from
f3f5fb0 to
4152603
Compare
|
Closing because I'm merging the top of the stack #44482 into master using slash-approve-and-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #44398 (in part)
This is a purely mechanical change that renames
StreamPartitionsCreatorintoJdbcPartitionsCreatorandStreamPartitionReaderintoJdbcPartitionReader. This makes the next PR's diff easier to read.