Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract-jdbc: better handling of NULL cursor values #44452

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Aug 20, 2024

In source-oracle, empty tables incorrectly trigger a ConfigErrorException because SELECT MAX(...) will return NULL even when the table is empty.

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:56pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Aug 20, 2024
@postamar postamar marked this pull request as ready for review August 20, 2024 15:33
@postamar postamar requested a review from a team as a code owner August 20, 2024 15:33
@postamar postamar force-pushed the postamar_gt_08-20-extract-jdbc_better_handling_of_null_cursor_values branch from 51279be to 639f09c Compare August 20, 2024 15:44
@postamar postamar requested a review from a team as a code owner August 20, 2024 15:44
@postamar postamar changed the base branch from postamar_gt_08-20-extract-jdbc_cursor_incremental_query_includes_lb to postamar_gt_08-20-extract-jdbc_add_greaterorequal August 20, 2024 15:44
@postamar postamar force-pushed the postamar_gt_08-20-extract-jdbc_add_greaterorequal branch from 23f0ac8 to efdfacf Compare August 20, 2024 18:47
@postamar postamar force-pushed the postamar_gt_08-20-extract-jdbc_better_handling_of_null_cursor_values branch from 639f09c to 35ce6ae Compare August 20, 2024 18:47
@postamar postamar force-pushed the postamar_gt_08-20-extract-jdbc_add_greaterorequal branch from efdfacf to 6c36470 Compare August 20, 2024 20:56
@postamar postamar force-pushed the postamar_gt_08-20-extract-jdbc_better_handling_of_null_cursor_values branch from 35ce6ae to 3131abd Compare August 20, 2024 20:56
@postamar
Copy link
Contributor Author

Closing because I'm merging the top of the stack #44482 into master using slash-approve-and-merge.

@postamar postamar closed this Aug 21, 2024
@postamar
Copy link
Contributor Author

Closing because I'm merging the top of the stack #44482 into master using slash-approve-and-merge.

@postamar postamar reopened this Aug 21, 2024
@postamar postamar closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants