bulk-cdk: refactor tests #44459
Closed
bulk-cdk: refactor tests #44459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Aug 20, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 20, 2024
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_add_and_adopt_jdbcpartition_and_jdbcpartitionfactory
branch
from
b377b33 to
6a4767b
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk_refactor_tests
branch
2 times, most recently
from
878507d to
0384db3
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_add_and_adopt_jdbcpartition_and_jdbcpartitionfactory
branch
from
6a4767b to
76136ec
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk_refactor_tests
branch
from
0384db3 to
1f15b54
Compare
postamar
force-pushed
the
postamar_gt_08-20-extract-jdbc_add_and_adopt_jdbcpartition_and_jdbcpartitionfactory
branch
from
76136ec to
a37b4b3
Compare
postamar
force-pushed
the
postamar_gt_08-20-bulk-cdk_refactor_tests
branch
from
1f15b54 to
bc3b932
Compare
|
Closing because I'm merging the top of the stack #44482 into master using slash-approve-and-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/airbytehq/airbyte-internal-issues/issues/9093
This PR pays down the technical debt which has been accumulated in the Bulk CDK's tests. The JDBC toolkit is in a good state, which makes it possible to move tests and tests fixtures to their proper places.
This PR doesn't change any of the tests, it just moves them around.