-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.2 Deployment #3084
6.2 Deployment #3084
Conversation
Using random made the test fails for some runs and succeed for others
…ing the action of running the compiled methods Also, in line with change to ExtensionMethodToCall, update to allow for different number of parameters This also changes to cache the functions based on similar string as used for ExtensionMethodToCall, rather than method info, as the same method info can be used for different functions, depending on the number of provided parameters, if the method info contains optional arguments (arguments with default values)
Should men no change in functional behaviour, but just more clearly highlight the intent of this method
…d add versioning for deleted public methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against new floor configurator test script, all works as expected. Structures components can be approved.
@BHoMBot check branch-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
@BHoMBot check branch-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
The check |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 77 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 127 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed against beta test artefacts during final sprint and approved by DevOps.
FAO: @FraserGreenroyd The check they wish to have dispensation on is beta-code-compliance. If you are providing dispensation on this occasion, please reply with:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is beta-documentation-compliance. If you are providing dispensation on this occasion, please reply with:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is beta-project-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441741233 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441744621 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441752453 |
@FraserGreenroyd I have now provided a passing check on reference |
FAO: @FraserGreenroyd The check they wish to have dispensation on is beta-beta-ready-status. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14422331620 |
@FraserGreenroyd I have now provided a passing check on reference |
@bhombot-ci[bot] just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks completed. DevOps clear to deploy 6.2
BHoM_Engine
Feature
ToList()
to the concatenated diffs inQuery.CombinedDiff()
Bug
Compliance
Documentation