Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.2 Deployment #3084

Merged
merged 153 commits into from
Jun 21, 2023
Merged

6.2 Deployment #3084

merged 153 commits into from
Jun 21, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Jun 12, 2023

BHoMBot and others added 30 commits June 12, 2023 22:56
Using random made the test fails for some runs and succeed for others
…ing the action of running the compiled methods

Also, in line with change to ExtensionMethodToCall, update to allow for different number of parameters
This also changes to cache the functions based on similar string as used for ExtensionMethodToCall, rather than method info, as the same method info can be used for different functions, depending on the number of provided parameters, if the method info contains optional arguments (arguments with default values)
Should men no change in functional behaviour, but just more clearly highlight the intent of this method
Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against new floor configurator test script, all works as expected. Structures components can be approved.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check branch-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check branch-compliance

There are 7 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check branch-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check branch-compliance

There are 14 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

The check beta-branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 5 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 77 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 127 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against beta test artefacts during final sprint and approved by DevOps.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441741233

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441744621

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441752453

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441741233

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd I have now provided a passing check on reference 14441741233 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441744621

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd I have now provided a passing check on reference 14441744621 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14441752453

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd I have now provided a passing check on reference 14441752453 as requested.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-beta-ready-status.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14422331620

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14422331620

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd I have now provided a passing check on reference 14422331620 as requested.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks completed. DevOps clear to deploy 6.2

@FraserGreenroyd FraserGreenroyd merged commit dbb6c39 into main Jun 21, 2023
@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines and removed type:feature New capability or enhancement labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.