Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection_Engine: methods dealing with input classification attributes aligned to changes in oM #3060

Merged

Conversation

pawelbaran
Copy link
Member

This PR is a new version of #3046

Set up from scratch due to funky commit history

NOTE: Depends on

BHoM/BHoM#1511

Issues addressed by this PR

Closes #

Test files

See BHoM/BHoM#1511

Changelog

Additional comments

See BHoM/BHoM#1511

@pawelbaran pawelbaran added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge type:feature New capability or enhancement labels May 29, 2023
@pawelbaran pawelbaran self-assigned this May 29, 2023
@pawelbaran pawelbaran requested a review from alelom May 29, 2023 10:57
@pawelbaran pawelbaran force-pushed the BHoM-#1508-FileExtensionsPropAddedToFilePathAttribute branch from 0dc5871 to 8ad7908 Compare June 7, 2023 14:57
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes align with discussions and stuff on the oM change so happy to approve for deployment.

@FraserGreenroyd FraserGreenroyd removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jun 7, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@pawelbaran just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit 34a943b into develop Jun 7, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#1508-FileExtensionsPropAddedToFilePathAttribute branch June 7, 2023 21:02
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants