-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection_Engine: methods dealing with input classification attributes aligned to changes in oM #3060
Reflection_Engine: methods dealing with input classification attributes aligned to changes in oM #3060
Conversation
0dc5871
to
8ad7908
Compare
@pawelbaran just to let you know, I have provided a |
@pawelbaran just to let you know, I have provided a |
@pawelbaran just to let you know, I have provided a |
@pawelbaran to confirm, the following actions are now queued:
|
@pawelbaran just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes align with discussions and stuff on the oM change so happy to approve for deployment.
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@pawelbaran just to let you know, I have provided a |
This PR is a new version of #3046
Set up from scratch due to funky commit history
NOTE: Depends on
BHoM/BHoM#1511
Issues addressed by this PR
Closes #
Test files
See BHoM/BHoM#1511
Changelog
Additional comments
See BHoM/BHoM#1511