Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical_Engine: Add support for GeneralMaterialTakeoff #3047

Merged
merged 12 commits into from
May 9, 2023

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented May 8, 2023

NOTE: Depends on

BHoM/BHoM#1516

Issues addressed by this PR

  • Adds first support methods and collection system for GeneralMaterialTakeoff class
  • Add Aggregation and mapping support for GeneralMaterialTakeoff
  • Add GeneralTakeoff capability for physical surface obejcts
  • Add method to generate a general takeoff given a construction and an area.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Physical_oM/%231516-AddGeneralTakeoffObject?csf=1&web=1&e=iAsS7e

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label May 8, 2023
@IsakNaslundBh IsakNaslundBh self-assigned this May 8, 2023
@IsakNaslundBh IsakNaslundBh requested a review from adecler as a code owner May 8, 2023 13:54
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 8, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 14 requests in the queue ahead of you.

michaelhoehn
michaelhoehn previously approved these changes May 8, 2023
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this with the provided sample script and everything works as expected. Nicely done @IsakNaslundBh 👍

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check unit-tests
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh changed the title Phsyical_Engine: Add support for GeneralMaterialTakeoff Physical_Engine: Add support for GeneralMaterialTakeoff May 9, 2023
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check code-compliance
@BHoMBot check copyright-compliance
@BHoMBot check documentation-compliance
@BHoMBot check project-compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests
  • check code-compliance
  • check copyright-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation

There are 29 requests in the queue ahead of you.

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 615ffc4 and 675fe72 based on code changes and the previous approving review.

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

The check unit-tests has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit a498583 into develop May 9, 2023
@FraserGreenroyd FraserGreenroyd deleted the Physical_oM-#1502-AddGeneralTakeoffObject branch May 9, 2023 08:18
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants