-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physical_Engine: Add support for GeneralMaterialTakeoff #3047
Physical_Engine: Add support for GeneralMaterialTakeoff #3047
Conversation
… volumetric takeoff
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this with the provided sample script and everything works as expected. Nicely done @IsakNaslundBh 👍
@IsakNaslundBh to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 29 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check |
The check |
The check |
The check |
The check |
The check |
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
BHoM/BHoM#1516
Issues addressed by this PR
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Physical_oM/%231516-AddGeneralTakeoffObject?csf=1&web=1&e=iAsS7e
Changelog
Additional comments