-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Engine: Created DocumentationURL #3073
BHoM_Engine: Created DocumentationURL #3073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this - we don't call the documentation a wiki, we refer to it as documentation, and I wonder if therefore the method should reflect that as well? One to discuss in addition to the comments on the code, but great start @desaiwangBH 😄
@BHoMBot check compliance |
@desaiwangBH to confirm, the following actions are now queued:
|
@BHoMBot check required |
@desaiwangBH to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, thanks @desaiwangBH
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Created GetWikiURL
method name change to better reflect function
Co-authored-by: Fraser Greenroyd <[email protected]>
Changed GetDocumentationURL to DocumentationURL and also resolved merge conflicts.
0baef74
to
21ac418
Compare
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, installer, serialisation, ready-to-merge, null-handling, unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Issues addressed by this PR
Closes #3027
Added a method to create links to the BHoM wiki documentation.
Test files
Changelog
Additional comments