Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: NullReferenceException on transform of a bar with null nodes fixed #3030

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Mar 23, 2023

Issues addressed by this PR

Closes #3029

Test files

On SharePoint.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Mar 23, 2023
@pawelbaran pawelbaran self-assigned this Mar 23, 2023
@pawelbaran pawelbaran requested a review from rwemay as a code owner March 23, 2023 17:54
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve.

Null handling and messages makes sense.

Happy for this to be merged to be included in 6.1 beta as a really low-risk PR only adding null-checking. Not required for 6.1 release, though, so can wait until 6.2 milestone if that is preferred by DevOps. @FraserGreenroyd

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 11 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 6e4afb8 into develop Mar 27, 2023
@FraserGreenroyd FraserGreenroyd deleted the Structure_Engine-#3029-BarTransformBug branch March 27, 2023 11:09
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: NullReferenceException on transform of a bar with null nodes
3 participants