Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighting_Engine: Align to Luminaire oM Orientation Change #3038

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Apr 12, 2023

NOTE: Depends on

BHoM/BHoM#1501

Issues addressed by this PR

Closes #3037

Changed Luminaire and Transform methods to accommodate new Orientation property.

Test files

test files

@enarhi enarhi requested a review from JohnSloane April 12, 2023 17:31
@enarhi enarhi changed the title Lighting_Engine: Algn to Luminaire oM Orientation Change Lighting_Engine: Align to Luminaire oM Orientation Change Apr 12, 2023
@enarhi
Copy link
Member Author

enarhi commented Apr 12, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member Author

enarhi commented Apr 12, 2023

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2023

@enarhi to confirm, the following actions are now queued:

  • check core

@enarhi
Copy link
Member Author

enarhi commented Apr 12, 2023

@BHoMBot check unit-tests
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2023

@enarhi to confirm, the following actions are now queued:

  • check unit-tests
  • check null-handling

@enarhi
Copy link
Member Author

enarhi commented Apr 12, 2023

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2023

@enarhi to confirm, the following actions are now queued:

  • check unit-tests

There are 12 requests in the queue ahead of you.

@enarhi
Copy link
Member Author

enarhi commented Apr 12, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2023

@enarhi just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @enarhi on Versioning_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2023

@enarhi just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @enarhi on BHoM

@enarhi enarhi added the type:feature New capability or enhancement label Apr 12, 2023
JohnSloane
JohnSloane previously approved these changes Apr 12, 2023
Copy link

@JohnSloane JohnSloane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All appears to be working as expected. I tested this with the test files in rhino and gh to ensure all orientation is working appropriately with all engine methods.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@enarhi just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @enarhi on Versioning_Toolkit

Lighting_Engine/Create/Luminaire.cs Outdated Show resolved Hide resolved
Lighting_Engine/Create/Luminaire.cs Show resolved Hide resolved
@enarhi
Copy link
Member Author

enarhi commented Apr 13, 2023

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@enarhi to confirm, the following actions are now queued:

  • check versioning

There are 23 requests in the queue ahead of you.

@enarhi
Copy link
Member Author

enarhi commented Apr 13, 2023

@BHoMBot check code-compliance
@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check copyright-compliance
  • check project-compliance

There are 26 requests in the queue ahead of you.

@enarhi
Copy link
Member Author

enarhi commented Apr 13, 2023

@BHoMBot check documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@enarhi to confirm, the following actions are now queued:

  • check documentation-compliance

There are 54 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@enarhi just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @enarhi on Versioning_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check unit-tests

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit only fixed my changes, functionality review from @JohnSloane still valid.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 14, 2023

@enarhi just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 14, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit d0e4026 into develop Apr 14, 2023
@FraserGreenroyd FraserGreenroyd deleted the Lighting_oM-#1500-UpdateOrientationProperty branch April 14, 2023 08:48
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighting_Engine: Update Lighting methods for change to Orientation on Luminaire
3 participants