-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighting_Engine: Align to Luminaire oM Orientation Change #3038
Lighting_Engine: Align to Luminaire oM Orientation Change #3038
Conversation
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check core |
@enarhi to confirm, the following actions are now queued:
|
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@enarhi to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All appears to be working as expected. I tested this with the test files in rhino and gh to ensure all orientation is working appropriately with all engine methods.
@BHoMBot check versioning |
@enarhi to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
@enarhi to confirm, the following actions are now queued:
There are 26 requests in the queue ahead of you. |
@BHoMBot check documentation-compliance |
@enarhi to confirm, the following actions are now queued:
There are 54 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last commit only fixed my changes, functionality review from @JohnSloane still valid.
@enarhi just to let you know, I have provided a |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
BHoM/BHoM#1501
Issues addressed by this PR
Closes #3037
Changed Luminaire and Transform methods to accommodate new Orientation property.
Test files
test files