Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: fix Router error when useAuth isn't passed #2038

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Mar 19, 2021

Hooks need to run in a predictable order.

If useAuth isn't passed to the router, it should use the default one from @redwoodjs/auth

@github-actions
Copy link

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/create-redwood-app-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-api-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-api-server-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-auth-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-cli-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-core-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-dev-server-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-eslint-config-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-eslint-plugin-redwood-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-forms-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-internal-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-prerender-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-router-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-structure-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-testing-0.27.1-414af85.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2038/redwoodjs-web-0.27.1-414af85.tgz

Install this PR by running yarn rw upgrade --pr 2038:0.27.1-414af85

@Tobbe Tobbe merged commit 44608cc into redwoodjs:main Mar 19, 2021
@thedavidprice thedavidprice added this to the next release milestone Mar 19, 2021
@thedavidprice thedavidprice changed the title Router: Fix auth Auth: fix Router error when useAuth isn't passed Mar 19, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Mar 22, 2021
…r-rwt-link

* 'main' of github.com:redwoodjs/redwood: (26 commits)
  Router: Fix auth (redwoodjs#2038)
  Steps towards a11y for Redwood Router (redwoodjs#1817)
  Router: <Set wrap={}> (redwoodjs#1898)
  Pass event and context into getCurrentUser (redwoodjs#1908)
  Implement Redwood API side Logger (redwoodjs#1937)
  Fixed path on windows to allow for pages under subdirectories (redwoodjs#2022)
  Add experimental ESBuild for api side (redwoodjs#1948)
  Upgrade to Prisma 2.19.0 (Prisma Migrate GA) (redwoodjs#2021)
  Fix lint breaking when deleting a side (redwoodjs#2017)
  Refactor: Converted Prisma.ts to js (redwoodjs#1958)
  Fix issue with verify email redirect using Auth0 (redwoodjs#1990)
  add GitHub Action CodeQL Analysis (redwoodjs#1951)
  fix: correct var name for grabbing user config (redwoodjs#2002)
  Create functions to fs calls (redwoodjs#2007)
  Return signup Output (redwoodjs#1992)
  Add makeExecSchema options (redwoodjs#1964)
  upgrade gotrue-js to 0.9.29 (redwoodjs#2011)
  Azure Active Directory Auth: Adding try-catch block on callback to capture empty key (redwoodjs#2010)
  withCellHOC: Fix TS error (redwoodjs#1967)
  Update error message in tasks/publish-local to point to tasks/run-local-npm when Verdaccio isn't running (redwoodjs#2004)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants