Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL Analysis GitHub Action #1951

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

thedavidprice
Copy link
Contributor

@thedavidprice thedavidprice commented Mar 10, 2021

Related to #1953

GitHub CodeQL Doc

  • confirm builds and runs correctly
  • what/where is the output after run; especially in case of alert?
  • adjust cron as needed

@github-actions
Copy link

github-actions bot commented Mar 10, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/create-redwood-app-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-api-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-api-server-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-auth-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-cli-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-core-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-dev-server-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-eslint-config-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-eslint-plugin-redwood-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-forms-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-internal-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-prerender-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-router-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-structure-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-testing-0.27.1-cf94201.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1951/redwoodjs-web-0.27.1-cf94201.tgz

Install this PR by running yarn rw upgrade --pr 1951:0.27.1-cf94201

@cypress
Copy link

cypress bot commented Mar 10, 2021



Test summary

11 0 1 0Flakiness 0


Run details

Project RedwoodJS Framework
Status Passed
Commit 83f8be6 ℹ️
Started Mar 17, 2021 4:54 AM
Ended Mar 17, 2021 4:57 AM
Duration 03:02 💡
OS Linux Ubuntu - 20.04
Browser Chrome 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thedavidprice
Copy link
Contributor Author

thedavidprice commented Mar 10, 2021

Run example here:
https://github.com/redwoodjs/redwood/pull/1951/checks?check_run_id=2071874081

Very interesting + helpful. (Also not sure what "1 analysis not found" means — yet):
https://github.com/redwoodjs/redwood/pull/1951/checks?check_run_id=2071889791

edit:

Also this summary of alerts in Security Settings (visible only to maintainers):
https://github.com/redwoodjs/redwood/security/code-scanning

@thedavidprice thedavidprice merged commit 31e3ac6 into main Mar 17, 2021
@thedavidprice thedavidprice deleted the dsp-add-workflow-codeql branch March 17, 2021 05:00
dac09 added a commit to dac09/redwood that referenced this pull request Mar 22, 2021
…r-rwt-link

* 'main' of github.com:redwoodjs/redwood: (26 commits)
  Router: Fix auth (redwoodjs#2038)
  Steps towards a11y for Redwood Router (redwoodjs#1817)
  Router: <Set wrap={}> (redwoodjs#1898)
  Pass event and context into getCurrentUser (redwoodjs#1908)
  Implement Redwood API side Logger (redwoodjs#1937)
  Fixed path on windows to allow for pages under subdirectories (redwoodjs#2022)
  Add experimental ESBuild for api side (redwoodjs#1948)
  Upgrade to Prisma 2.19.0 (Prisma Migrate GA) (redwoodjs#2021)
  Fix lint breaking when deleting a side (redwoodjs#2017)
  Refactor: Converted Prisma.ts to js (redwoodjs#1958)
  Fix issue with verify email redirect using Auth0 (redwoodjs#1990)
  add GitHub Action CodeQL Analysis (redwoodjs#1951)
  fix: correct var name for grabbing user config (redwoodjs#2002)
  Create functions to fs calls (redwoodjs#2007)
  Return signup Output (redwoodjs#1992)
  Add makeExecSchema options (redwoodjs#1964)
  upgrade gotrue-js to 0.9.29 (redwoodjs#2011)
  Azure Active Directory Auth: Adding try-catch block on callback to capture empty key (redwoodjs#2010)
  withCellHOC: Fix TS error (redwoodjs#1967)
  Update error message in tasks/publish-local to point to tasks/run-local-npm when Verdaccio isn't running (redwoodjs#2004)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant