AuthProvider: return signup() output from auth client
#1992
Conversation
When you signup via Supabase you get all the meta data back in the return of the `signup` call. We now eat all that output instead of giving it back to the user. I noticed that we already do something similar to Sign In, so I basically took that concept and applied that for signUp as well.
There was a problem hiding this comment.
@jvanbaarsen I think this is fine. @Tobbe what do you think?
The playground auth should be updated with this PR to test too.
In fact there are a few Supabase updates that need to be done to get up to current including redirectTo and oauth scope support.
|
I think this is the correct behavior. But, this is where semver is difficult. Is this a breaking change or not? Theoretically it is, |
|
@Tobbe My feel is that this is not really a "breaking" change. We can mention it in the release notes so the 0.00001% of people run into this are aware of the problem. |
|
In the auth example I'm wondering how https://github.com/redwoodjs/playground-auth/blob/main/web/src/components/Supabase/Supabase.js#L81 could have worked. Since Supabase eats up the error that they throw and add it to the return object, so an error is never thrown. Or was that the old integration they used? |
|
@jvanbaarsen Yeah, you might be right. They changed that back in Oct of last year. https://supabase.io/blog/2020/10/30/improved-dx |
Tobbe
changed the title
signup() output from auth client
|
@Tobbe @jvanbaarsen @dthyresson
Thanks again! |
|
I did that with the intent to merge as soon as all checks had completed, but then I had to go pick up the kids. I'll try again. |
RW's Sorry. That's two sentences. |
|
@Tobbe Thanks for taking this across the line! |
…r-rwt-link * 'main' of github.com:redwoodjs/redwood: (26 commits) Router: Fix auth (redwoodjs#2038) Steps towards a11y for Redwood Router (redwoodjs#1817) Router: <Set wrap={}> (redwoodjs#1898) Pass event and context into getCurrentUser (redwoodjs#1908) Implement Redwood API side Logger (redwoodjs#1937) Fixed path on windows to allow for pages under subdirectories (redwoodjs#2022) Add experimental ESBuild for api side (redwoodjs#1948) Upgrade to Prisma 2.19.0 (Prisma Migrate GA) (redwoodjs#2021) Fix lint breaking when deleting a side (redwoodjs#2017) Refactor: Converted Prisma.ts to js (redwoodjs#1958) Fix issue with verify email redirect using Auth0 (redwoodjs#1990) add GitHub Action CodeQL Analysis (redwoodjs#1951) fix: correct var name for grabbing user config (redwoodjs#2002) Create functions to fs calls (redwoodjs#2007) Return signup Output (redwoodjs#1992) Add makeExecSchema options (redwoodjs#1964) upgrade gotrue-js to 0.9.29 (redwoodjs#2011) Azure Active Directory Auth: Adding try-catch block on callback to capture empty key (redwoodjs#2010) withCellHOC: Fix TS error (redwoodjs#1967) Update error message in tasks/publish-local to point to tasks/run-local-npm when Verdaccio isn't running (redwoodjs#2004) ...
When you signup via Supabase you get all the meta data back in the
return of the
signupcall. We now eat all that output instead ofgiving it back to the user.
I noticed that we already do something similar to Sign In, so I
basically took that concept and applied that for signUp as well.
@dthyresson Do you think we break people's app by not returning
reauthenticate()?