Fix issue with verify email redirect using Auth0 #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@o0charlie0o anything I can do to help this along? |
|
@peterp I think it mainly needs to be tested although I have done that locally without issue. I put it in draft due to that failing test but I'm not really sure why it failed at the moment. |
|
Let me re-run the tests, since those failures look completely unrelated. |
peterp
reviewed
Mar 17, 2021
peterp
approved these changes
Mar 17, 2021
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Mar 22, 2021
…r-rwt-link * 'main' of github.com:redwoodjs/redwood: (26 commits) Router: Fix auth (redwoodjs#2038) Steps towards a11y for Redwood Router (redwoodjs#1817) Router: <Set wrap={}> (redwoodjs#1898) Pass event and context into getCurrentUser (redwoodjs#1908) Implement Redwood API side Logger (redwoodjs#1937) Fixed path on windows to allow for pages under subdirectories (redwoodjs#2022) Add experimental ESBuild for api side (redwoodjs#1948) Upgrade to Prisma 2.19.0 (Prisma Migrate GA) (redwoodjs#2021) Fix lint breaking when deleting a side (redwoodjs#2017) Refactor: Converted Prisma.ts to js (redwoodjs#1958) Fix issue with verify email redirect using Auth0 (redwoodjs#1990) add GitHub Action CodeQL Analysis (redwoodjs#1951) fix: correct var name for grabbing user config (redwoodjs#2002) Create functions to fs calls (redwoodjs#2007) Return signup Output (redwoodjs#1992) Add makeExecSchema options (redwoodjs#1964) upgrade gotrue-js to 0.9.29 (redwoodjs#2011) Azure Active Directory Auth: Adding try-catch block on callback to capture empty key (redwoodjs#2010) withCellHOC: Fix TS error (redwoodjs#1967) Update error message in tasks/publish-local to point to tasks/run-local-npm when Verdaccio isn't running (redwoodjs#2004) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking the verify email link in an Auth0 email upon success Auth0 redirects to the main url defined with a bunch of search params. One of those params happens to be
code=whichrestoreAuthStatelooks for in theAuthProvider. It does not however include thestateparam causing the rest of this function to fail with an invalid state error. This PR makes sure bothcodeandstateexist before continuing with the redirect callback.Example of the url Auth0 redirects to:
https://www.sample-website.com/?supportSignUp=true&supportForgotPassword=true&email=email%40sample-website.com&message=Your%20email%20was%20verified.%20You%20can%20continue%20using%20the%20application.&success=true&code=success#