Add makeExecSchema options #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
thedavidprice
added
release:breaking
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Mar 22, 2021
…r-rwt-link * 'main' of github.com:redwoodjs/redwood: (26 commits) Router: Fix auth (redwoodjs#2038) Steps towards a11y for Redwood Router (redwoodjs#1817) Router: <Set wrap={}> (redwoodjs#1898) Pass event and context into getCurrentUser (redwoodjs#1908) Implement Redwood API side Logger (redwoodjs#1937) Fixed path on windows to allow for pages under subdirectories (redwoodjs#2022) Add experimental ESBuild for api side (redwoodjs#1948) Upgrade to Prisma 2.19.0 (Prisma Migrate GA) (redwoodjs#2021) Fix lint breaking when deleting a side (redwoodjs#2017) Refactor: Converted Prisma.ts to js (redwoodjs#1958) Fix issue with verify email redirect using Auth0 (redwoodjs#1990) add GitHub Action CodeQL Analysis (redwoodjs#1951) fix: correct var name for grabbing user config (redwoodjs#2002) Create functions to fs calls (redwoodjs#2007) Return signup Output (redwoodjs#1992) Add makeExecSchema options (redwoodjs#1964) upgrade gotrue-js to 0.9.29 (redwoodjs#2011) Azure Active Directory Auth: Adding try-catch block on callback to capture empty key (redwoodjs#2010) withCellHOC: Fix TS error (redwoodjs#1967) Update error message in tasks/publish-local to point to tasks/run-local-npm when Verdaccio isn't running (redwoodjs#2004) ...
|
I don't think this is fully working like expected createGraphQLHandler({
getCurrentUser,
schema: makeMergedSchema({
schemas: {
...schemas,
...stripeSchema,
},
services: makeServices({ services }),
schemaOptions: {
resolverValidationOptions: {
requireResolversForResolveType: false,
},
},
}),After trying this it does not seem to have removed the console errors for union types like it should be. I also get an typescript error saying i need to define typeDefs if i have defined, schemaOptions |
|
I've contacted Peter directly. I Will see if there's anything to be done for v0.28. If not can do a patch release (given prioritization) or get in the next release. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user to specify
schemaOptionstomakeExecutableSchemaviamakeMergedSchema({ schemaOptions:{} }).We already included a single
schemaDirectiveoption inmakeMergedSchema,so I'm deprecating that (@thedavidprice) and asking people to useschemaOptionsinstead.Closes #1957