Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding keyboard: neuron #7980

Merged
merged 17 commits into from
Feb 8, 2020
Merged

adding keyboard: neuron #7980

merged 17 commits into from
Feb 8, 2020

Conversation

worldspawn00
Copy link
Contributor

Description

adding keyboard: neuron

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ridingqwerty
ridingqwerty requested changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change include guards to #pragma once, change bootloader options to BOOTLOADER = atmel-dfu, remove firmware size changes from rules.mk options.

keyboards/walletburner/neuron/keymaps/default/keymap.c Outdated
Comment on lines 16 to 22

[2] = LAYOUT(
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS)

Copy link
Contributor

@ridingqwerty ridingqwerty Jan 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be removed since there's no access to it from lower layers and it's all KC_TRANS. If you do, remove the comma from the end of layer 1.

drashna
drashna requested changes Jan 25, 2020
View reviewed changes
keyboards/walletburner/neuron/config.h Outdated
Comment on lines 42 to 48
/* key combination for command */
#define IS_COMMAND() ( \
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
)

/* prevent stuck modifiers */
#define PREVENT_STUCK_MODIFIERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IS_COMMAND() macro only needs to be defined here if you're changing the default setting.

PREVENT_STUCK_MODIFIERS is now the default behaviour for QMK, project wide.

worldspawn00 and others added 13 commits January 28, 2020 00:39
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/neuron.h
67916ca 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/neuron.h
da4dcf6 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/config.h
ac40155 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/config.h
0a29904 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/config.h
5b213e9 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/rules.mk
32805bd 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/rules.mk
caac62b 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/rules.mk
ef16760 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/rules.mk
f3a0edc 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @ridingqwerty
Update keyboards/walletburner/neuron/rules.mk
a40da71 
Co-Authored-By: ridingqwerty <[email protected]>
@worldspawn00 @drashna
Update keyboards/walletburner/neuron/readme.md
470266e 
Co-Authored-By: Drashna Jaelre <[email protected]>
@worldspawn00 @drashna
Update keyboards/walletburner/neuron/readme.md
1342171 
Co-Authored-By: Drashna Jaelre <[email protected]>
@worldspawn00 @drashna
Update keyboards/walletburner/neuron/readme.md
551aa32 
Co-Authored-By: Drashna Jaelre <[email protected]>
drashna
drashna reviewed Jan 29, 2020
View reviewed changes
keyboards/walletburner/neuron/rules.mk Outdated
Comment on lines 47 to 56
BOOTMAGIC_ENABLE ?= yes # Virtual DIP switch configuration
MOUSEKEY_ENABLE ?= yes # Mouse keys
EXTRAKEY_ENABLE ?= yes # Audio control and System control
CONSOLE_ENABLE ?= no # Console for debug
COMMAND_ENABLE ?= no # Commands for debug and configuration
SLEEP_LED_ENABLE ?= no # Breathing sleep LED during USB suspend
NKRO_ENABLE ?= yes # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
BACKLIGHT_ENABLE ?= no # Enable keyboard backlight functionality
AUDIO_ENABLE ?= no
RGBLIGHT_ENABLE ?= yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the question marks be removed from the settings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I know, yes.

@ridingqwerty ridingqwerty requested a review from drashna February 5, 2020 16:26
@ridingqwerty
Copy link
Contributor

ridingqwerty commented Feb 5, 2020 •
edited
Loading

Just added the recent review suggestions made and requested another look from @drashna

@drashna drashna merged commit dd6f925 into qmk:master Feb 8, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 8, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
15a145e 
* 'master' of https://github.com/qmk/qmk_firmware: (24 commits)
  CI: Add workflow for CLI testing (qmk#7357)
  Add Prime_L V2 and Prime_EXL Plus (qmk#8111)
  [Keyboard] adding keyboard: neuron (qmk#7980)
  [Keyboard] adding keyboard: pain27 (qmk#7977)
  [Keyboard] adding keyboard: sl40 (qmk#7978)
  [Keyboard] adding keyboard: houndstooth (qmk#7981)
  [Keyboard] adding keyboard: kodachi50 (qmk#7976)
  [Keyboard] adding keyboard: gothic70 (qmk#7982)
  [Keyboard] adding keyboard: gothic50 (qmk#7983)
  [Keyboard] YMDK NP21: matrix and keymap refactor (qmk#8112)
  [Keymap] Added keymap for keebio/nyquist (qmk#8108)
  [Keyboard] Port SPLIT_USB_DETECT to lily58 (qmk#8107)
  [Keymap] Phoebe/Maxr1998 keymap: enable space cadet with curly braces (qmk#8096)
  [Keymap] add lily58 yshrsmz keymap (qmk#8095)
  [Keyboard] Remove i2c write command when reading columns on Ergodox EZ (qmk#8092)
  [Keyboard] Misc tidyups for Chidori (qmk#8091)
  [Keymap] Add users/alfrdmalr and switch to layouts (qmk#8030)
  XD84: Configurator bugfix for ISO layout (qmk#8117)
  ZJ68: complete Configurator layout support (qmk#8116)
  Add QMK Compile Context Sensitivity (qmk#6884)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@worldspawn00 @ridingqwerty
@drashna @HokieGeek
[Keyboard] adding keyboard: neuron (qmk#7980)
70db8dd 
* neuron

* Update keyboards/walletburner/neuron/neuron.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/neuron.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Committed review suggestions

* Corrected bootloader to use atmel-dfu

* One last tweak to correct MANUFACTURER

Co-authored-by: ridingqwerty <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@worldspawn00 @ridingqwerty
@drashna @c0psrul3
[Keyboard] adding keyboard: neuron (qmk#7980)
0f06b0a 
* neuron

* Update keyboards/walletburner/neuron/neuron.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/neuron.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Committed review suggestions

* Corrected bootloader to use atmel-dfu

* One last tweak to correct MANUFACTURER

Co-authored-by: ridingqwerty <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@worldspawn00 @ridingqwerty
@drashna @kujawakk
[Keyboard] adding keyboard: neuron (qmk#7980)
f60d6a4 
* neuron

* Update keyboards/walletburner/neuron/neuron.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/neuron.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/config.h

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/rules.mk

Co-Authored-By: ridingqwerty <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/walletburner/neuron/readme.md

Co-Authored-By: Drashna Jaelre <[email protected]>

* Committed review suggestions

* Corrected bootloader to use atmel-dfu

* One last tweak to correct MANUFACTURER

Co-authored-by: ridingqwerty <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@worldspawn00 @ridingqwerty @drashna @Duckle29