Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add users/alfrdmalr and switch to layouts #8030

Merged
merged 29 commits into from
Feb 8, 2020

Conversation

alfrdmalr
Copy link
Contributor

Description

Adds my keymap/config stuff to a users folder to share between keyboards.
Also migrated all my Preonic code to live between the users and layouts folders.

I'm utilizing the layout wrappers approach seen in Drashna's userspace (looks like originally designed by @jola5?). It looks a little different from most of the implementations I've seen, since I don't really have any layers with shared mods that don't just use transparency, but should function basically the same. The main focus here was to get the layers in the same place, so that I only need to make a single change that gets pushed to all boards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team January 28, 2020 22:18
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drashna drashna merged commit 707c04b into qmk:master Feb 8, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 8, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (24 commits)
  CI: Add workflow for CLI testing (qmk#7357)
  Add Prime_L V2 and Prime_EXL Plus (qmk#8111)
  [Keyboard] adding keyboard: neuron (qmk#7980)
  [Keyboard] adding keyboard: pain27 (qmk#7977)
  [Keyboard] adding keyboard: sl40 (qmk#7978)
  [Keyboard] adding keyboard: houndstooth (qmk#7981)
  [Keyboard] adding keyboard: kodachi50 (qmk#7976)
  [Keyboard] adding keyboard: gothic70 (qmk#7982)
  [Keyboard] adding keyboard: gothic50 (qmk#7983)
  [Keyboard] YMDK NP21: matrix and keymap refactor (qmk#8112)
  [Keymap] Added keymap for keebio/nyquist (qmk#8108)
  [Keyboard] Port SPLIT_USB_DETECT to lily58 (qmk#8107)
  [Keymap] Phoebe/Maxr1998 keymap: enable space cadet with curly braces (qmk#8096)
  [Keymap] add lily58 yshrsmz keymap (qmk#8095)
  [Keyboard] Remove i2c write command when reading columns on Ergodox EZ (qmk#8092)
  [Keyboard] Misc tidyups for Chidori (qmk#8091)
  [Keymap] Add users/alfrdmalr and switch to layouts (qmk#8030)
  XD84: Configurator bugfix for ISO layout (qmk#8117)
  ZJ68: complete Configurator layout support (qmk#8116)
  Add QMK Compile Context Sensitivity (qmk#6884)
  ...
@alfrdmalr alfrdmalr deleted the feature/userspace-alfrdmalr branch February 16, 2020 01:16
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* WIP do not merge

* first pass at custom preonic layout

* add auto shift and reset via leader key

* Update readme

* update copyright notice

* formatting changes

* fix: use MO instead of process_record_user

* added backslash and moved grave position

* remove extraneous 'j' characer in NUMPAD template

* update template formatting

* remove process_record_user

* swap "!" with "@"

* fix readme formatting

* update readme layout image

* restore settings layer

* add windows minimize sequence

* fix: switch to correct seq function for three-key sequence

* fix: missing semicolon

* refactor: move keymap to userspace and generic 5x12 layout

* add numlock to numpad layer

* add readme

* update readme formatting

* remove unused wrappers from layout keymap

* update readme title to reflect new location

* remove alfrdmalr directory from preonic/keymaps

* clean up user config
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
* WIP do not merge

* first pass at custom preonic layout

* add auto shift and reset via leader key

* Update readme

* update copyright notice

* formatting changes

* fix: use MO instead of process_record_user

* added backslash and moved grave position

* remove extraneous 'j' characer in NUMPAD template

* update template formatting

* remove process_record_user

* swap "!" with "@"

* fix readme formatting

* update readme layout image

* restore settings layer

* add windows minimize sequence

* fix: switch to correct seq function for three-key sequence

* fix: missing semicolon

* refactor: move keymap to userspace and generic 5x12 layout

* add numlock to numpad layer

* add readme

* update readme formatting

* remove unused wrappers from layout keymap

* update readme title to reflect new location

* remove alfrdmalr directory from preonic/keymaps

* clean up user config
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* WIP do not merge

* first pass at custom preonic layout

* add auto shift and reset via leader key

* Update readme

* update copyright notice

* formatting changes

* fix: use MO instead of process_record_user

* added backslash and moved grave position

* remove extraneous 'j' characer in NUMPAD template

* update template formatting

* remove process_record_user

* swap "!" with "@"

* fix readme formatting

* update readme layout image

* restore settings layer

* add windows minimize sequence

* fix: switch to correct seq function for three-key sequence

* fix: missing semicolon

* refactor: move keymap to userspace and generic 5x12 layout

* add numlock to numpad layer

* add readme

* update readme formatting

* remove unused wrappers from layout keymap

* update readme title to reflect new location

* remove alfrdmalr directory from preonic/keymaps

* clean up user config
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* WIP do not merge

* first pass at custom preonic layout

* add auto shift and reset via leader key

* Update readme

* update copyright notice

* formatting changes

* fix: use MO instead of process_record_user

* added backslash and moved grave position

* remove extraneous 'j' characer in NUMPAD template

* update template formatting

* remove process_record_user

* swap "!" with "@"

* fix readme formatting

* update readme layout image

* restore settings layer

* add windows minimize sequence

* fix: switch to correct seq function for three-key sequence

* fix: missing semicolon

* refactor: move keymap to userspace and generic 5x12 layout

* add numlock to numpad layer

* add readme

* update readme formatting

* remove unused wrappers from layout keymap

* update readme title to reflect new location

* remove alfrdmalr directory from preonic/keymaps

* clean up user config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants