Add Prime_L V2 and Prime_EXL Plus #8111

holtenc · 2020-02-07T03:22:23Z

Description

Adding firmware for two new PCBs. Prime_L V2 will be produced. Prime_EXL Plus is a personal project, hence why it's in /handwired.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

function of indicator lights was inverted. these changes correct that.

upstream sync

correct key spacing.

holtenc · 2020-02-07T05:39:36Z

not sure what the fail is all about. It builds just fine locally.

fauxpark · 2020-02-07T05:41:52Z

The keyboard name needs to be lowercase.

keyboards/handwired/prime_exl_plus/keymaps/default/config.h

keyboards/handwired/prime_exl_plus/keymaps/default/keymap.c

keyboards/primekb/Prime_l_v2/rules.mk

holtenc · 2020-02-07T06:44:45Z

Decided to drop adding Prime_EXL Plus from QMK as it will never be used by anyone other than myself. Made all other changes requested under Prime_L V2. But never did find where you mentioned the keyboard name needs to be lower case...

fauxpark · 2020-02-07T07:12:45Z

I'm referring to the folder name:

…me_l_v2/config.h

holtenc · 2020-02-07T16:19:34Z

folder name fixed. it was fixed locally a while ago which is why I wasn't seeing what you were talkinga bout. but I guess that change doesn't get pushed to github?? either way. it's done.

drashna · 2020-02-08T03:13:49Z

Yeah, the casing is ... troublesome, which is why we generally want all lower case. It can cause issues on some OS's... As you've demonstrated. :)

drashna

Looks good

fauxpark

Thanks!

* 'master' of https://github.com/qmk/qmk_firmware: (24 commits) CI: Add workflow for CLI testing (qmk#7357) Add Prime_L V2 and Prime_EXL Plus (qmk#8111) [Keyboard] adding keyboard: neuron (qmk#7980) [Keyboard] adding keyboard: pain27 (qmk#7977) [Keyboard] adding keyboard: sl40 (qmk#7978) [Keyboard] adding keyboard: houndstooth (qmk#7981) [Keyboard] adding keyboard: kodachi50 (qmk#7976) [Keyboard] adding keyboard: gothic70 (qmk#7982) [Keyboard] adding keyboard: gothic50 (qmk#7983) [Keyboard] YMDK NP21: matrix and keymap refactor (qmk#8112) [Keymap] Added keymap for keebio/nyquist (qmk#8108) [Keyboard] Port SPLIT_USB_DETECT to lily58 (qmk#8107) [Keymap] Phoebe/Maxr1998 keymap: enable space cadet with curly braces (qmk#8096) [Keymap] add lily58 yshrsmz keymap (qmk#8095) [Keyboard] Remove i2c write command when reading columns on Ergodox EZ (qmk#8092) [Keyboard] Misc tidyups for Chidori (qmk#8091) [Keymap] Add users/alfrdmalr and switch to layouts (qmk#8030) XD84: Configurator bugfix for ISO layout (qmk#8117) ZJ68: complete Configurator layout support (qmk#8116) Add QMK Compile Context Sensitivity (qmk#6884) ...

noroadsleft · 2020-02-08T19:48:07Z

So... this looks like an updated version of the Prime_L. Any reason why this wasn't added as a subfolder (keyboards/primekb/prime_l/v2/)?

holtenc · 2020-02-08T22:36:57Z

@noroadsleft no reason other than it didn't occur to me and I'm not familiar with the process/file/folder structure. If you insist on it I'll play with it and submit a new PR

noroadsleft · 2020-02-09T02:59:16Z

Let me work on it and I'll send you a commit or PR. Might be tomorrow though.

holtenc · 2020-02-09T03:29:22Z

I have no problem figuring it out myself. as I noted in the qmk_configurator PR the two different PCB versions need a differing info.json. I'm just not familiar enough with how _configurator works with _firmware to know if it's possible to put an additional info.json in a subfolder like you can with rules.mk

noroadsleft · 2020-02-13T21:49:02Z

This is what I get for not checking my GitHub notifications.

https://github.com/noroadsleft/qmk_firmware/tree/rf/prime_l/keyboards/primekb/prime_l

Anyway, each revision can have its own info.json file. The idea is to only duplicate the parts that are different between revisions, and have everything else in common between the revisions hosted at the keyboard level.

Use all of the changes, or none. I really only intended this to be a sample.

Important Notes:

noroadsleft:rf/prime_l, keyboards/primekb/prime_l/rules.mk#L35

... makes it so calling make primekb/prime_l calls make primekb/prime_l/v1, because moving the folders means the make command needed changes. I did not create a similar configuration for the V2, and in truth, many of us within QMK want to deprecate and later eliminate DEFAULT_FOLDER completely.

noroadsleft:rf/prime_l, keyboards/primekb/prime_l/v2/rules.mk#L1

This line isn't actually required (it's the same as in keyboards/primekb/prime_l/rules.mk), but the file itself is. QMK requires a rules.mk be present in order to treat the directory as that of a buildable keyboard.

keyboards/primekb/prime_l/keymaps/

This implementation only works when all revisions share a similar physical layout. As both revisions use a four/two/four configuration on the bottom row for the alpha area, the change in keysizes between revisions isn't relevant. Each revision uses the appropriate layout macro, which is set up between keyboards/primekb/prime_l/prime_l.h, keyboards/primekb/prime_l/v1/v1.h, and keyboards/primekb/prime_l/v2/v2.h.

holtenc · 2020-02-17T21:16:00Z

@noroadsleft sorry it's taken me so long to respond. Thank so much for setting that up and explaining it. I've looked at examples from other keyboards that have multiple revisions (Iris etc) but it's a lot easier for me to follow what's going on when I'm already familiar with the keyboard firmware, such as this. It all looks fine to me. I haven't done a test build with these changes yet but should be able to get to that this week. I'll get it all tested and submit a new PR ASAP. Should I just close the _configurator PR?

noroadsleft · 2020-02-17T21:39:16Z

@noroadsleft sorry it's taken me so long to respond. Thank so much for setting that up and explaining it. I've looked at examples from other keyboards that have multiple revisions (Iris etc) but it's a lot easier for me to follow what's going on when I'm already familiar with the keyboard firmware, such as this. It all looks fine to me. I haven't done a test build with these changes yet but should be able to get to that this week. I'll get it all tested and submit a new PR ASAP. Should I just close the _configurator PR?

Go ahead and leave the Configurator PR open; I can mark it on hold and later walk you through updating it.

* correct indicator light states. function of indicator lights was inverted. these changes correct that. * flesh out keymaps pre production * Enable extrakey in rules * Prime_BLE initial commit * Initial commit for Prime_L V2 * Update info.json correct key spacing. * update copyright * Update readme.md * Inital commit * updates before PR into QMK master * Drop Prime_EXL Plus from PR. Make requested changes to Prime_L V2 * Rename keyboards/primekb/Prime_l_v2/config.h to keyboards/primekb/prime_l_v2/config.h * Rename keyboards/primekb/prime_l_v2/config.h to keyboards/primekb/Prime_l_v2/config.h * remove directory Prime_l_v2 * re-submit with proper folder name.

holtenc added 13 commits March 17, 2019 23:16

correct indicator light states.

3dc21e9

function of indicator lights was inverted. these changes correct that.

flesh out keymaps pre production

6a8f6bd

Enable extrakey in rules

cafd59f

Merge remote-tracking branch 'upstream/master'

b8c2432

upstream sync

Merge remote-tracking branch 'upstream/master'

1602f6d

Prime_BLE initial commit

b98aa8a

Merge branch 'master' of https://github.com/qmk/qmk_firmware

e12b4ae

Initial commit for Prime_L V2

dc48de8

Update info.json

b9666b1

correct key spacing.

update copyright

5d4d62a

Update readme.md

e091d2d

Inital commit

ce66807

updates before PR into QMK master

ac9ac00

fauxpark requested changes Feb 7, 2020

View reviewed changes

fauxpark added keyboard keymap labels Feb 7, 2020

fauxpark requested a review from a team February 7, 2020 05:51

Drop Prime_EXL Plus from PR. Make requested changes to Prime_L V2

1cb1675

holtenc and others added 5 commits February 7, 2020 07:21

Rename keyboards/primekb/Prime_l_v2/config.h to keyboards/primekb/pri…

c580822

…me_l_v2/config.h

Rename keyboards/primekb/prime_l_v2/config.h to keyboards/primekb/Pri…

80523fc

…me_l_v2/config.h

remove directory Prime_l_v2

bb265a8

Merge branch 'master' of https://github.com/holtenc/qmk_firmware

bb31ea8

re-submit with proper folder name.

de610d7

drashna approved these changes Feb 8, 2020

View reviewed changes

fauxpark approved these changes Feb 8, 2020

View reviewed changes

fauxpark merged commit 8fe29f2 into qmk:master Feb 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Prime_L V2 and Prime_EXL Plus #8111

Add Prime_L V2 and Prime_EXL Plus #8111

holtenc commented Feb 7, 2020 •

edited

Loading

holtenc commented Feb 7, 2020

fauxpark commented Feb 7, 2020

holtenc commented Feb 7, 2020

fauxpark commented Feb 7, 2020

holtenc commented Feb 7, 2020 •

edited

Loading

drashna commented Feb 8, 2020

drashna left a comment

fauxpark left a comment

noroadsleft commented Feb 8, 2020

holtenc commented Feb 8, 2020

noroadsleft commented Feb 9, 2020

holtenc commented Feb 9, 2020

noroadsleft commented Feb 13, 2020

holtenc commented Feb 17, 2020

noroadsleft commented Feb 17, 2020

Add Prime_L V2 and Prime_EXL Plus #8111

Add Prime_L V2 and Prime_EXL Plus #8111

Conversation

holtenc commented Feb 7, 2020 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

holtenc commented Feb 7, 2020

fauxpark commented Feb 7, 2020

holtenc commented Feb 7, 2020

fauxpark commented Feb 7, 2020

holtenc commented Feb 7, 2020 • edited Loading

drashna commented Feb 8, 2020

drashna left a comment

Choose a reason for hiding this comment

fauxpark left a comment

Choose a reason for hiding this comment

noroadsleft commented Feb 8, 2020

holtenc commented Feb 8, 2020

noroadsleft commented Feb 9, 2020

holtenc commented Feb 9, 2020

noroadsleft commented Feb 13, 2020

Important Notes:

noroadsleft:rf/prime_l, keyboards/primekb/prime_l/rules.mk#L35

noroadsleft:rf/prime_l, keyboards/primekb/prime_l/v2/rules.mk#L1

keyboards/primekb/prime_l/keymaps/

holtenc commented Feb 17, 2020

noroadsleft commented Feb 17, 2020

holtenc commented Feb 7, 2020 •

edited

Loading

holtenc commented Feb 7, 2020 •

edited

Loading