-
-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding keyboard: kodachi50 #7976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change include guards to #pragma once
Replace atomic bootloader options with BOOTLOADER = caterina
Remove firmware filesize changes from rules.mk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to start another review, but added some slight rules.mk
adjustments.
Committed collaborator suggestions, requesting another look from @drashna |
Added a missing keycode to top row of layer 2, Travis is happy now. |
* 'master' of https://github.com/qmk/qmk_firmware: (24 commits) CI: Add workflow for CLI testing (qmk#7357) Add Prime_L V2 and Prime_EXL Plus (qmk#8111) [Keyboard] adding keyboard: neuron (qmk#7980) [Keyboard] adding keyboard: pain27 (qmk#7977) [Keyboard] adding keyboard: sl40 (qmk#7978) [Keyboard] adding keyboard: houndstooth (qmk#7981) [Keyboard] adding keyboard: kodachi50 (qmk#7976) [Keyboard] adding keyboard: gothic70 (qmk#7982) [Keyboard] adding keyboard: gothic50 (qmk#7983) [Keyboard] YMDK NP21: matrix and keymap refactor (qmk#8112) [Keymap] Added keymap for keebio/nyquist (qmk#8108) [Keyboard] Port SPLIT_USB_DETECT to lily58 (qmk#8107) [Keymap] Phoebe/Maxr1998 keymap: enable space cadet with curly braces (qmk#8096) [Keymap] add lily58 yshrsmz keymap (qmk#8095) [Keyboard] Remove i2c write command when reading columns on Ergodox EZ (qmk#8092) [Keyboard] Misc tidyups for Chidori (qmk#8091) [Keymap] Add users/alfrdmalr and switch to layouts (qmk#8030) XD84: Configurator bugfix for ISO layout (qmk#8117) ZJ68: complete Configurator layout support (qmk#8116) Add QMK Compile Context Sensitivity (qmk#6884) ...
* kodachi50 * Amendeded with collaborator suggestions * Add a missing key to layer 2 top row Co-authored-by: ridingqwerty <[email protected]>
* kodachi50 * Amendeded with collaborator suggestions * Add a missing key to layer 2 top row Co-authored-by: ridingqwerty <[email protected]>
* kodachi50 * Amendeded with collaborator suggestions * Add a missing key to layer 2 top row Co-authored-by: ridingqwerty <[email protected]>
Description
adding keyboard: kodachi50
Types of Changes
Issues Fixed or Closed by This PR
Checklist