Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepared plan cache: Enable by default #4036

Merged
merged 4 commits into from Oct 13, 2020
Merged

prepared plan cache: Enable by default #4036

merged 4 commits into from Oct 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2020 •
edited by ghost
Loading

What is changed, added or deleted? (Required)

This PR covers the docs portion of pingcap/tidb#20306

It only applies to master. It can be reviewed now, but should merge after pingcap/tidb#20416 is merged.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ghost ghost mentioned this pull request Oct 12, 2020
Merged
@ghost ghost added the status/PTAL This PR is ready for reviewing. label Oct 12, 2020
zz-jason
zz-jason reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2020
@TomShawn TomShawn added size/medium Changes of a medium size. translation/doing This PR's assignee is translating this PR. labels Oct 13, 2020
TomShawn
TomShawn reviewed Oct 13, 2020
View reviewed changes
@ghost ghost added the requires-followup This PR requires a follow-up task after being merged. label Oct 13, 2020
TomShawn
TomShawn approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 13, 2020
@TomShawn TomShawn merged commit 6000b95 into pingcap:master Oct 13, 2020
TomShawn added a commit that referenced this pull request Oct 13, 2020
@TomShawn
Revert "prepared plan cache: Enable by default (#4036)"
73d215b 
This reverts commit 6000b95.
@TomShawn TomShawn added the v5.0 This PR/issue applies to TiDB v5.0. label Oct 16, 2020
@Joyinqin Joyinqin mentioned this pull request Oct 19, 2020
Merged
9 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Oct 20, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Oct 20, 2020
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Nov 5, 2020
@morgo morgo mentioned this pull request Mar 11, 2021
Merged
eurekaka added a commit to eurekaka/docs that referenced this pull request Mar 11, 2021
@eurekaka
Revert "prepared plan cache: Enable by default (pingcap#4036)"
06f71a7 
This reverts commit 6000b95.
@eurekaka eurekaka mentioned this pull request Mar 11, 2021
Merged
11 tasks
eurekaka added a commit to eurekaka/docs that referenced this pull request Mar 11, 2021
@eurekaka
Revert "prepared plan cache: Enable by default (pingcap#4036)"
08823bf 
This reverts commit 6000b95.
eurekaka added a commit to eurekaka/docs that referenced this pull request Mar 11, 2021
@eurekaka
Revert "prepared plan cache: Enable by default (pingcap#4036)"
bfefecd 
This reverts commit 6000b95.
eurekaka added a commit to eurekaka/docs that referenced this pull request Mar 12, 2021
@eurekaka
Revert "prepared plan cache: Enable by default (pingcap#4036)"
edbc49d 
This reverts commit 6000b95.
eurekaka added a commit to eurekaka/docs that referenced this pull request Mar 15, 2021
@eurekaka
Revert "prepared plan cache: Enable by default (pingcap#4036)"
bbdc5b2 
This reverts commit 6000b95.
ti-chi-bot pushed a commit that referenced this pull request Mar 23, 2021
@eurekaka
Revert "prepared plan cache: Enable by default (#4036)" (#5007)
bbd7e20
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
11 tasks
ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@ti-srebot
Revert "prepared plan cache: Enable by default (#4036)" (#5007) (#5078)
943f512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees

@Joyinqin Joyinqin

Labels
size/medium Changes of a medium size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joyinqin @zz-jason @TomShawn @ti-srebot