planner, config: Enable plan cache by default #20416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
ghost
mentioned this pull request
github-actions
bot
added
component/expression
sig/execution
ti-srebot
approved these changes
Oct 13, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
|
@nullnotnil merge failed. |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #20306
Problem Summary:
Prepared Plan Cache has been validated by QA as stable, and starting with TiDB 5.0 is safe to be enabled by default. This PR still offers the toggle to disable the cache (which is technically obsolete, since you could set the capacity of the cache to zero as well). I think this makes sense for now because several other stable features still have an 'enable' flag, but I can adjust if reviewers would like me to take another look.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn: prepared plan cache: Enable by default docs#4036Check List
Tests
Side effects
Release note