Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: disable prepare plan cache by default #23240

Merged
merged 4 commits into from
Mar 11, 2021
Merged

config: disable prepare plan cache by default #23240

merged 4 commits into from
Mar 11, 2021

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #23239

Problem Summary:

Disable prepare plan cache by default.

What is changed and how it works?

What's Changed:

Change default config for prepare plan cache to false.

Related changes

N/A

Check List

Tests

  • Unit test: current tests should cover this change

Side effects

N/A

Release note

  • Disable prepare plan cache by default

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. component/config labels Mar 10, 2021
@eurekaka eurekaka requested a review from a team as a code owner March 10, 2021 09:29
@eurekaka eurekaka requested review from XuHuaiyu and removed request for a team March 10, 2021 09:29
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 10, 2021
@eurekaka
Copy link
Contributor Author

/run-check_dev_2

@eurekaka eurekaka removed the request for review from XuHuaiyu March 10, 2021 09:37
@eurekaka eurekaka force-pushed the disable_plan_cache branch from 9407916 to 42d7a14 Compare March 10, 2021 09:49
@eurekaka eurekaka requested a review from a team as a code owner March 10, 2021 09:49
@eurekaka eurekaka requested review from qw4990 and removed request for a team March 10, 2021 09:49
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka
Copy link
Contributor Author

/run-all-tests

Reminiscent
Reminiscent approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

@Reminiscent: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented Mar 11, 2021

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Mar 11, 2021
@xhebox
Copy link
Contributor

xhebox commented Mar 11, 2021

/remove-sig sql-infra

@ti-chi-bot ti-chi-bot removed the sig/sql-infra SIG: SQL Infra label Mar 11, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 11, 2021
@morgo
Copy link
Contributor

morgo commented Mar 11, 2021

The docs PR for enabling plan cache was: pingcap/docs#4036
A corresponding PR will be required to revert it too.

@eurekaka eurekaka mentioned this pull request Mar 11, 2021
Merged
11 tasks
zz-jason
zz-jason previously approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@zz-jason: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@zz-jason zz-jason dismissed their stale review March 11, 2021 05:48

need another LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • zz-jason

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2021
@eurekaka
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 42d7a14

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2021
@eurekaka
Copy link
Contributor Author

/run-unit-test

@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka
Copy link
Contributor Author

/run-check_dev_2

@eurekaka
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot
Copy link
Member

@eurekaka: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@eurekaka eurekaka merged commit 07b19e0 into pingcap:master Mar 11, 2021
@eurekaka eurekaka deleted the disable_plan_cache branch March 11, 2021 08:26
@zyguan zyguan mentioned this pull request Mar 18, 2021
Closed
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
11 tasks
@cfzjywxk cfzjywxk mentioned this pull request May 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
component/config component/expression sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disable prepare plan cache by default
7 participants
@eurekaka @ti-chi-bot @xhebox @morgo @zz-jason @qw4990 @Reminiscent