Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "prepared plan cache: Enable by default (#4036)" #5007

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Revert "prepared plan cache: Enable by default (#4036)" #5007

merged 1 commit into from
Mar 23, 2021

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Mar 11, 2021 •
edited by yikeke
Loading

This reverts commit 6000b95.

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@eurekaka eurekaka force-pushed the revert_plan_cache branch from 06f71a7 to 08823bf Compare March 11, 2021 03:46
morgo
morgo reviewed Mar 11, 2021
View reviewed changes
@eurekaka eurekaka force-pushed the revert_plan_cache branch from 08823bf to bfefecd Compare March 11, 2021 03:53
@eurekaka eurekaka requested a review from morgo March 11, 2021 03:53
@morgo
Copy link
Contributor

morgo commented Mar 11, 2021

/label needs-cherry-pick-5.0

@morgo
Copy link
Contributor

morgo commented Mar 11, 2021

LGTM

@morgo
Copy link
Contributor

morgo commented Mar 11, 2021

It looks like this needs a 5.0 cherry pick as well. I'm not sure why my bot command failed, but I don't have permissions through the GitHub GUI to add the labels.

TomShawn
TomShawn reviewed Mar 11, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added translation/doing This PR's assignee is translating this PR. size/small Changes of a small size. status/require-change Needs the author to address comments. labels Mar 11, 2021
@eurekaka eurekaka force-pushed the revert_plan_cache branch from a0a7a45 to edbc49d Compare March 12, 2021 08:10
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/small Changes of a small size. labels Mar 12, 2021
@ti-srebot
Copy link
Contributor

@eurekaka, please update your pull request.

@TomShawn
Copy link
Contributor

@eurekaka Please resolve the conflict. Rest LGTM

@eurekaka eurekaka force-pushed the revert_plan_cache branch from edbc49d to bbdc5b2 Compare March 15, 2021 08:04
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2021
@eurekaka eurekaka requested a review from TomShawn March 15, 2021 08:04
@TomShawn
Copy link
Contributor

/remove-status require-change
/lgtm

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/require-change Needs the author to address comments. labels Mar 15, 2021
@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Mar 15, 2021 •
edited
Loading

@eurekaka Is this PR v5.0 GA related? If so, please add the v5.0 label.

@TomShawn
Copy link
Contributor

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2021
@eurekaka
Copy link
Contributor Author

/label v5.0

@ti-chi-bot ti-chi-bot added the v5.0 This PR/issue applies to TiDB v5.0. label Mar 15, 2021
@eurekaka
Copy link
Contributor Author

@TomShawn ptal

@TomShawn
Copy link
Contributor

TomShawn commented Mar 16, 2021 •
edited
Loading

@eurekaka Because this is a 5.0 GA-related content, its delivery is planned and controlled. We'll merge this PR later.

@morgo morgo mentioned this pull request Mar 17, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

@eurekaka, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor

@eurekaka, please update your pull request.

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2021
@ti-srebot
Copy link
Contributor

@eurekaka, please update your pull request.

@ti-srebot
Copy link
Contributor

No updates for a long time, close PR.

@ti-chi-bot ti-chi-bot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. status/can-merge Indicates a PR has been approved by a committer. labels Mar 23, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bbdc5b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2021
@ti-chi-bot ti-chi-bot merged commit bbd7e20 into pingcap:master Mar 23, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 23, 2021
@eurekaka @ti-srebot
cherry pick pingcap#5007 to release-5.0
9d9e600 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5078

@Joyinqin Joyinqin mentioned this pull request Mar 24, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 24, 2021
@Joyinqin
Copy link
Contributor

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR's assignee is translating this PR. label Mar 24, 2021
ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021
@ti-srebot
Revert "prepared plan cache: Enable by default (#4036)" (#5007) (#5078)
943f512
@ti-srebot ti-srebot mentioned this pull request Mar 26, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo Awaiting requested review from morgo

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@Joyinqin Joyinqin

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eurekaka @morgo @ti-srebot @TomShawn @ran-huang @ti-chi-bot @Joyinqin