Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepared plan cache: Enable by default #4714

Merged
merged 11 commits into from
Oct 22, 2020
Merged

prepared plan cache: Enable by default #4714

merged 11 commits into from
Oct 22, 2020

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Oct 19, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

/label follow-up, size/medium, v5.0, translation/from-docs

@ti-srebot ti-srebot added requires-followup This PR requires a follow-up task after being merged. size/medium Changes of a medium size. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.0 This PR/issue applies to TiDB v5.0 labels Oct 19, 2020
@Joyinqin
Copy link
Contributor Author

/cc yikeke, zz-jason

@ti-srebot ti-srebot requested review from yikeke and zz-jason October 20, 2020 03:48
@Joyinqin Joyinqin marked this pull request as ready for review October 20, 2020 03:48
yikeke
yikeke reviewed Oct 21, 2020
View reviewed changes
zz-jason
zz-jason reviewed Oct 21, 2020
View reviewed changes
yikeke
yikeke approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2020
zz-jason
zz-jason approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2020
@yikeke yikeke merged commit bf67af2 into pingcap:master Oct 22, 2020
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@yikeke yikeke yikeke approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
size/medium Changes of a medium size. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @zz-jason @yikeke @ti-srebot @TomShawn