Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

bitfield-dist: fix state update on gossip #2817

Merged
5 commits merged into from
Apr 4, 2021
Merged

Conversation

ordian
Copy link
Member

@ordian ordian commented Apr 4, 2021

  • fixes a bug in bitfield distribution introduced in gossip: choose a random subset on send instead of limiting connections #2776 spotted by @rphmeier when we updated state for all peers but sended only to a subset, now we update state only for a subset
  • changes how we are choose subset in statement-distrubution not to rely on hashmap ordering
    • I've considered using a type-safe wrapper in send, but couldn't find an easy way (need to store hashmap entries?)

@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 4, 2021
@ordian ordian marked this pull request as draft April 4, 2021 21:28
@ordian ordian marked this pull request as ready for review April 4, 2021 21:39
@rphmeier
Copy link
Contributor

rphmeier commented Apr 4, 2021

bot merge

@ghost
Copy link

ghost commented Apr 4, 2021

Waiting for commit status.

@ghost ghost merged commit 72318d7 into master Apr 4, 2021
@ghost ghost deleted the ao-fixes-for-gossip-selection branch April 4, 2021 22:25
rphmeier pushed a commit that referenced this pull request Apr 4, 2021
* bitfield-dist: fix state update on gossip

* fixes

* doc fixes

* oops

* 2 lines of code change
ordian added a commit that referenced this pull request Apr 5, 2021
* master:
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
ordian added a commit that referenced this pull request Apr 5, 2021
* master: (40 commits)
  tests: use future::join instead of future::select (#2813)
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
  approval-distribution: split peer knowledge into sent and received (#2809)
  change some configuration for rococo (#2802)
  companion: update wasmtime to 0.24.0 (#2625)
  add disputes members to `HostConfiguration` (#2806)
  Ease parachain candidate code fetching (#2593)
  gossip: move authorities request to runtime api subsystem (#2798)
  remove training wheels (#2800)
  Approval Voting improvements (#2781)
  Companion PR for substrate#8510 (#2795)
  tweaks to relevant_authority_ids (#2796)
  Add dispute types and change InclusionInherent to ParasInherent (#2791)
  ...
ordian added a commit that referenced this pull request Apr 7, 2021
* master: (39 commits)
  Add Root Functions to HRMP (#2785)
  Relax Origin Checks in Registrar, Add Lock to Registration (#2808)
  remove WASM_MAGIC (#2832)
  update twox-hash (#2831)
  update rococo genesis (#2830)
  parachain db versioning (#2829)
  statement-distribution: do not verify signatures for duplicate statements (#2823)
  Enable debug assertions on burn-in PRs (#2826)
  parachain_db: fix incorrect config cache sizes (#2827)
  Properly remove peers from sets and merge the two Network traits (#2821)
  tests: use future::join instead of future::select (#2813)
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
  approval-distribution: split peer knowledge into sent and received (#2809)
  ...
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants