Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

feat: Add poke to Crowdloan #2807

Merged
merged 6 commits into from
Apr 4, 2021
Merged

feat: Add poke to Crowdloan #2807

merged 6 commits into from
Apr 4, 2021

Conversation

stanly-johnson
Copy link
Contributor

Resolves #2801

cc @shawntabrizi

@shawntabrizi
Copy link
Member

@stanly-johnson looks really close! Just a few nit picks

@shawntabrizi shawntabrizi added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 2, 2021
@shawntabrizi shawntabrizi merged commit a13f27e into paritytech:master Apr 4, 2021
@stanly-johnson stanly-johnson deleted the stanly-poke-crowdloan branch April 5, 2021 04:47
ordian added a commit that referenced this pull request Apr 5, 2021
@ordian
Merge branch 'master' into ao-fix-tests-early-exit
3323086 
* master:
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
ordian added a commit that referenced this pull request Apr 5, 2021
@ordian
Merge branch 'master' into ao-use-blake2-for-runtime-map-hashes
66b2801 
* master: (40 commits)
  tests: use future::join instead of future::select (#2813)
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
  approval-distribution: split peer knowledge into sent and received (#2809)
  change some configuration for rococo (#2802)
  companion: update wasmtime to 0.24.0 (#2625)
  add disputes members to `HostConfiguration` (#2806)
  Ease parachain candidate code fetching (#2593)
  gossip: move authorities request to runtime api subsystem (#2798)
  remove training wheels (#2800)
  Approval Voting improvements (#2781)
  Companion PR for substrate#8510 (#2795)
  tweaks to relevant_authority_ids (#2796)
  Add dispute types and change InclusionInherent to ParasInherent (#2791)
  ...
ordian added a commit that referenced this pull request Apr 7, 2021
@ordian
Merge branch 'master' into mp-srtool-fix
9d79f66 
* master: (39 commits)
  Add Root Functions to HRMP (#2785)
  Relax Origin Checks in Registrar, Add Lock to Registration (#2808)
  remove WASM_MAGIC (#2832)
  update twox-hash (#2831)
  update rococo genesis (#2830)
  parachain db versioning (#2829)
  statement-distribution: do not verify signatures for duplicate statements (#2823)
  Enable debug assertions on burn-in PRs (#2826)
  parachain_db: fix incorrect config cache sizes (#2827)
  Properly remove peers from sets and merge the two Network traits (#2821)
  tests: use future::join instead of future::select (#2813)
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
  approval-distribution: split peer knowledge into sent and received (#2809)
  ...
@stanly-johnson stanly-johnson mentioned this pull request Apr 14, 2021
Closed
@redzsina redzsina added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add poke to Crowdloan
3 participants
@stanly-johnson @shawntabrizi @redzsina