Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Create Macro for Implementing SlotRange #2788

Merged
merged 22 commits into from
Apr 4, 2021

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Mar 31, 2021

This PR sets up the work needed to increase the number of lease periods per slot to 8 (or any number).

That will come in a future PR if we determine it is what we want to do.

@shawntabrizi shawntabrizi marked this pull request as draft March 31, 2021 17:21
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Mar 31, 2021
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 31, 2021
@shawntabrizi shawntabrizi marked this pull request as ready for review March 31, 2021 21:35
@shawntabrizi shawntabrizi changed the title Make Lease Periods Dynamic(-ish) in Runtime Create Macro for Implementing SlotRange Mar 31, 2021
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will need doc and test, but implementation is good to me, except #2788 (comment)

runtime/common/slot_range_helper/src/lib.rs Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Outdated Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Outdated Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Outdated Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Show resolved Hide resolved
@shawntabrizi shawntabrizi requested a review from gui1117 April 1, 2021 13:27
runtime/common/src/slot_range.rs Outdated Show resolved Hide resolved
runtime/common/slot_range_helper/Cargo.toml Outdated Show resolved Hide resolved
runtime/common/slot_range_helper/Cargo.toml Outdated Show resolved Hide resolved
runtime/common/Cargo.toml Outdated Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Outdated Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Show resolved Hide resolved
runtime/common/slot_range_helper/src/lib.rs Outdated Show resolved Hide resolved
shawntabrizi and others added 2 commits April 3, 2021 20:52
@gavofyork gavofyork merged commit 7370b70 into master Apr 4, 2021
@gavofyork gavofyork deleted the shawntabrizi-more-lease-periods branch April 4, 2021 11:11
ordian added a commit that referenced this pull request Apr 5, 2021
* master:
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
ordian added a commit that referenced this pull request Apr 5, 2021
* master: (40 commits)
  tests: use future::join instead of future::select (#2813)
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
  approval-distribution: split peer knowledge into sent and received (#2809)
  change some configuration for rococo (#2802)
  companion: update wasmtime to 0.24.0 (#2625)
  add disputes members to `HostConfiguration` (#2806)
  Ease parachain candidate code fetching (#2593)
  gossip: move authorities request to runtime api subsystem (#2798)
  remove training wheels (#2800)
  Approval Voting improvements (#2781)
  Companion PR for substrate#8510 (#2795)
  tweaks to relevant_authority_ids (#2796)
  Add dispute types and change InclusionInherent to ParasInherent (#2791)
  ...
ordian added a commit that referenced this pull request Apr 7, 2021
* master: (39 commits)
  Add Root Functions to HRMP (#2785)
  Relax Origin Checks in Registrar, Add Lock to Registration (#2808)
  remove WASM_MAGIC (#2832)
  update twox-hash (#2831)
  update rococo genesis (#2830)
  parachain db versioning (#2829)
  statement-distribution: do not verify signatures for duplicate statements (#2823)
  Enable debug assertions on burn-in PRs (#2826)
  parachain_db: fix incorrect config cache sizes (#2827)
  Properly remove peers from sets and merge the two Network traits (#2821)
  tests: use future::join instead of future::select (#2813)
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
  approval-distribution: split peer knowledge into sent and received (#2809)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants