This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Crowdloan Dissolve Requires All Funds Refunded #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
github-actions
bot
added
A0-please_review
shawntabrizi
commented
Apr 1, 2021
shawntabrizi
added
B0-silent
kianenigma
reviewed
Apr 2, 2021
kianenigma
reviewed
Apr 2, 2021
kianenigma
reviewed
Apr 2, 2021
kianenigma
reviewed
Apr 2, 2021
kianenigma
approved these changes
Apr 2, 2021
Co-authored-by: Kian Paimani <[email protected]>
shawntabrizi
commented
Apr 2, 2021
shawntabrizi
commented
Apr 4, 2021
gavofyork
reviewed
Apr 4, 2021
gavofyork
approved these changes
Apr 4, 2021
Co-authored-by: Gavin Wood <[email protected]>
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: "Required status check "continuous-integration/gitlab-check-transaction-versions" is pending." |
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Apr 5, 2021
* master: finally get unbacked candidates to descend from root span correctly (#2819) Network bridge metrics (#2818) bitfield-dist: fix state update on gossip (#2817) Collators: Declare to all peers (#2816) feat: Add poke to Crowdloan (#2807) Crowdloan Dissolve Requires All Funds Refunded (#2770) Create Macro for Implementing `SlotRange` (#2788) Collation protocol: stricter validators (#2810)
ordian
added a commit
that referenced
this pull request
Apr 5, 2021
* master: (40 commits) tests: use future::join instead of future::select (#2813) finally get unbacked candidates to descend from root span correctly (#2819) Network bridge metrics (#2818) bitfield-dist: fix state update on gossip (#2817) Collators: Declare to all peers (#2816) feat: Add poke to Crowdloan (#2807) Crowdloan Dissolve Requires All Funds Refunded (#2770) Create Macro for Implementing `SlotRange` (#2788) Collation protocol: stricter validators (#2810) approval-distribution: split peer knowledge into sent and received (#2809) change some configuration for rococo (#2802) companion: update wasmtime to 0.24.0 (#2625) add disputes members to `HostConfiguration` (#2806) Ease parachain candidate code fetching (#2593) gossip: move authorities request to runtime api subsystem (#2798) remove training wheels (#2800) Approval Voting improvements (#2781) Companion PR for substrate#8510 (#2795) tweaks to relevant_authority_ids (#2796) Add dispute types and change InclusionInherent to ParasInherent (#2791) ...
ordian
added a commit
that referenced
this pull request
Apr 7, 2021
* master: (39 commits) Add Root Functions to HRMP (#2785) Relax Origin Checks in Registrar, Add Lock to Registration (#2808) remove WASM_MAGIC (#2832) update twox-hash (#2831) update rococo genesis (#2830) parachain db versioning (#2829) statement-distribution: do not verify signatures for duplicate statements (#2823) Enable debug assertions on burn-in PRs (#2826) parachain_db: fix incorrect config cache sizes (#2827) Properly remove peers from sets and merge the two Network traits (#2821) tests: use future::join instead of future::select (#2813) finally get unbacked candidates to descend from root span correctly (#2819) Network bridge metrics (#2818) bitfield-dist: fix state update on gossip (#2817) Collators: Declare to all peers (#2816) feat: Add poke to Crowdloan (#2807) Crowdloan Dissolve Requires All Funds Refunded (#2770) Create Macro for Implementing `SlotRange` (#2788) Collation protocol: stricter validators (#2810) approval-distribution: split peer knowledge into sent and received (#2809) ...
redzsina
added
D1-audited 👍
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for: paritytech/substrate#8478
This PR changes the logic for how a crowdloan is dissolved.
Before, there was a retirement state, where users had some limited window to withdraw their funds.
This PR removes this logic and instead requires that all funds are returned to users before the crowdloan can be dissolved.
It also introduces a nice helper function which will refund as many accounts as possible at once, rather than needing to call each refund one by one.