Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Collation protocol: stricter validators #2810

Merged
merged 22 commits into from
Apr 3, 2021
Merged

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Apr 3, 2021

Changes:

  • send ParaId in Declare, not AdvertiseCollation.
  • Disconnect peers who have not sent a Declare message within 1 second of connecting
  • Disconnect collators who have not declared for our current or next para assignment
  • Disconnect collators who declare for an para outside of our current or next assignments
  • Various cleanups

@rphmeier rphmeier added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 3, 2021
@rphmeier rphmeier added the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Apr 3, 2021
@rphmeier rphmeier merged commit 54e18e6 into master Apr 3, 2021
@rphmeier rphmeier deleted the rh-declare-one-para branch April 3, 2021 19:48
rphmeier added a commit that referenced this pull request Apr 3, 2021
* guide: declare one para as a collator

* add ParaId to Declare messages and clean up

* fix build

* fix the testerinos

* begin adding keystore to collator-protocol

* remove request_x_ctx

* add core_for_group

* add bump_rotation

* add some more helpers to subsystem-util

* change signing_key API to take ref

* determine current and next para assignments

* disconnect collators who are not on current or next para

* add collator peer count metric

* notes for later

* some fixes

* add data & keystore to test state

* add a test utility for answering runtime API requests

* fix existing collator tests

* add new tests

* remove sc_keystore

* update cargo lock

Co-authored-by: Andronik Ordian <[email protected]>
ordian added a commit that referenced this pull request Apr 5, 2021
* master:
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
ordian added a commit that referenced this pull request Apr 5, 2021
* master: (40 commits)
  tests: use future::join instead of future::select (#2813)
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
  approval-distribution: split peer knowledge into sent and received (#2809)
  change some configuration for rococo (#2802)
  companion: update wasmtime to 0.24.0 (#2625)
  add disputes members to `HostConfiguration` (#2806)
  Ease parachain candidate code fetching (#2593)
  gossip: move authorities request to runtime api subsystem (#2798)
  remove training wheels (#2800)
  Approval Voting improvements (#2781)
  Companion PR for substrate#8510 (#2795)
  tweaks to relevant_authority_ids (#2796)
  Add dispute types and change InclusionInherent to ParasInherent (#2791)
  ...
ordian added a commit that referenced this pull request Apr 7, 2021
* master: (39 commits)
  Add Root Functions to HRMP (#2785)
  Relax Origin Checks in Registrar, Add Lock to Registration (#2808)
  remove WASM_MAGIC (#2832)
  update twox-hash (#2831)
  update rococo genesis (#2830)
  parachain db versioning (#2829)
  statement-distribution: do not verify signatures for duplicate statements (#2823)
  Enable debug assertions on burn-in PRs (#2826)
  parachain_db: fix incorrect config cache sizes (#2827)
  Properly remove peers from sets and merge the two Network traits (#2821)
  tests: use future::join instead of future::select (#2813)
  finally get unbacked candidates to descend from root span correctly (#2819)
  Network bridge metrics (#2818)
  bitfield-dist: fix state update on gossip (#2817)
  Collators: Declare to all peers (#2816)
  feat: Add poke to Crowdloan (#2807)
  Crowdloan Dissolve Requires All Funds Refunded (#2770)
  Create Macro for Implementing `SlotRange` (#2788)
  Collation protocol: stricter validators (#2810)
  approval-distribution: split peer knowledge into sent and received (#2809)
  ...
@redzsina redzsina added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants