-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build-support/bin/deploy_to_s3.py. #17818
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken wheel deploys.
🤦 |
jsirois
commented
Dec 15, 2022
|
||
|
||
def perform_deploy(*, aws_cli_symlink_path: str | None = None, scope: str | None = None): | ||
def perform_deploy(*, aws_cli_symlink_path: str | None = None, scope: str | None = None) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aws_cli_symlink_path
param does get used, but the option and use are over here:
pants/build-support/bin/backfill_s3_release_tag_mappings.py
Lines 11 to 35 in 64a480d
def main(): | |
parser = argparse.ArgumentParser() | |
parser.add_argument( | |
"--aws-cli-symlink-path", | |
help=( | |
"The directory (on the $PATH) to symlink the `aws` cli binary into; by default a" | |
"standard PATH entry appropriate to the current operating system." | |
), | |
) | |
options = parser.parse_args() | |
tags_deploy_dir = Path("dist/deploy/tags/pantsbuild.pants") | |
tags_deploy_dir.mkdir(parents=True, exist_ok=False) | |
release_tags = subprocess.run( | |
["git", "tag", "--list", "release_*"], stdout=subprocess.PIPE, text=True, check=True | |
).stdout.splitlines() | |
for release_tag in release_tags: | |
tag = release_tag.strip() | |
commit = subprocess.run( | |
["git", "rev-parse", f"{tag}^{{commit}}"], stdout=subprocess.PIPE, text=True, check=True | |
).stdout.strip() | |
(tags_deploy_dir / tag).write_text(commit) | |
perform_deploy(aws_cli_symlink_path=options.aws_cli_symlink_path, scope="tags/pantsbuild.pants") |
benjyw
approved these changes
Dec 15, 2022
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Dec 15, 2022
Fix broken wheel deploys. (cherry picked from commit 2080691)
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Dec 15, 2022
Fix broken wheel deploys. (cherry picked from commit 2080691) # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
added a commit
that referenced
this pull request
Dec 15, 2022
jsirois
added a commit
that referenced
this pull request
Dec 15, 2022
Merged
stuhood
added a commit
that referenced
this pull request
Dec 17, 2022
### Internal * Get rid of `_ToolLockfileMixin`. ([#17823](#17823)) * Fix `build-support/bin/deploy_to_s3.py`. ([#17818](#17818)) * Upgrade setproctitle to 1.3.2 ([#17804](#17804)) * Document the release tag back-fill script. ([#17808](#17808)) * Add a release tag backfill script. ([#17806](#17806)) * Set up release tag mapping workflow. ([#17801](#17801)) * go: fix path lookup for copied header files ([#17798](#17798)) * go: set `replace_sandbox_root_in_args=True` since replacement is used ([#17797](#17797)) * go: set missing `Goal.environment_behavior` on a debug goal ([#17799](#17799)) * go: rename option to --go-test-coverage-packages ([#17795](#17795)) * A stub page for dep validation docs. ([#17788](#17788)) * Upgrade to newest remote execution proto ([#17786](#17786)) * Adding tests for `cc` dependency inference showing source roots as `include_directories` ([#17738](#17738)) * Fix validation of release PEXes. ([#17785](#17785)) * Unconditionally register export-codegen goal in pants.core ([#17782](#17782)) * go: allow exporting cgo codegen for third party packages ([#17770](#17770)) * Properly set `pex_root` when running python sources in-sandbox. ([#17750](#17750)) * Renames `output_files` and `output_directories` fields for `experimental_shell_command` ([#17744](#17744))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken wheel deploys.