Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-support/bin/deploy_to_s3.py. #17818

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Dec 15, 2022

Fix broken wheel deploys.

Fix broken wheel deploys.
@jsirois jsirois added needs-cherrypick category:internal CI, fixes for not-yet-released features, etc. labels Dec 15, 2022
@jsirois jsirois added this to the 2.14.x milestone Dec 15, 2022
@jsirois jsirois requested a review from benjyw December 15, 2022 05:19
@jsirois
Copy link
Contributor Author

jsirois commented Dec 15, 2022

🤦



def perform_deploy(*, aws_cli_symlink_path: str | None = None, scope: str | None = None):
def perform_deploy(*, aws_cli_symlink_path: str | None = None, scope: str | None = None) -> None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aws_cli_symlink_path param does get used, but the option and use are over here:

def main():
parser = argparse.ArgumentParser()
parser.add_argument(
"--aws-cli-symlink-path",
help=(
"The directory (on the $PATH) to symlink the `aws` cli binary into; by default a"
"standard PATH entry appropriate to the current operating system."
),
)
options = parser.parse_args()
tags_deploy_dir = Path("dist/deploy/tags/pantsbuild.pants")
tags_deploy_dir.mkdir(parents=True, exist_ok=False)
release_tags = subprocess.run(
["git", "tag", "--list", "release_*"], stdout=subprocess.PIPE, text=True, check=True
).stdout.splitlines()
for release_tag in release_tags:
tag = release_tag.strip()
commit = subprocess.run(
["git", "rev-parse", f"{tag}^{{commit}}"], stdout=subprocess.PIPE, text=True, check=True
).stdout.strip()
(tags_deploy_dir / tag).write_text(commit)
perform_deploy(aws_cli_symlink_path=options.aws_cli_symlink_path, scope="tags/pantsbuild.pants")

@jsirois jsirois merged commit 2080691 into pantsbuild:main Dec 15, 2022
@jsirois jsirois deleted the deploy_to_s3/fix branch December 15, 2022 05:59
jsirois added a commit to jsirois/pants that referenced this pull request Dec 15, 2022
Fix broken wheel deploys.

(cherry picked from commit 2080691)
jsirois added a commit to jsirois/pants that referenced this pull request Dec 15, 2022
Fix broken wheel deploys.

(cherry picked from commit 2080691)

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
jsirois added a commit that referenced this pull request Dec 15, 2022
Fix build-support/bin/deploy_to_s3.py. (#17818)

Fix broken wheel deploys.

(cherry picked from commit 2080691)
jsirois added a commit that referenced this pull request Dec 15, 2022
Fix build-support/bin/deploy_to_s3.py. (#17818)

Fix broken wheel deploys.

(cherry picked from commit 2080691)
@stuhood stuhood mentioned this pull request Dec 17, 2022
stuhood added a commit that referenced this pull request Dec 17, 2022
### Internal

* Get rid of `_ToolLockfileMixin`. ([#17823](#17823))

* Fix `build-support/bin/deploy_to_s3.py`. ([#17818](#17818))

* Upgrade setproctitle to 1.3.2 ([#17804](#17804))

* Document the release tag back-fill script. ([#17808](#17808))

* Add a release tag backfill script. ([#17806](#17806))

* Set up release tag mapping workflow. ([#17801](#17801))

* go: fix path lookup for copied header files ([#17798](#17798))

* go: set `replace_sandbox_root_in_args=True` since replacement is used ([#17797](#17797))

* go: set missing `Goal.environment_behavior` on a debug goal ([#17799](#17799))

* go: rename option to --go-test-coverage-packages ([#17795](#17795))

* A stub page for dep validation docs. ([#17788](#17788))

* Upgrade to newest remote execution proto ([#17786](#17786))

* Adding tests for `cc` dependency inference showing source roots as `include_directories` ([#17738](#17738))

* Fix validation of release PEXes. ([#17785](#17785))

* Unconditionally register export-codegen goal in pants.core ([#17782](#17782))

* go: allow exporting cgo codegen for third party packages ([#17770](#17770))

* Properly set `pex_root` when running python sources in-sandbox. ([#17750](#17750))

* Renames `output_files` and `output_directories` fields for `experimental_shell_command` ([#17744](#17744))
This was referenced Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants