-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a release tag backfill script. #17806
Conversation
The new script was used to successfully backfill all Pants release tag mappings to S3 and the release workflow is fixed to scope its sync to just tags and the underlying helper deploy_to_s3.py code to skip index.html generation when there is no data to generate it from.
Backfill session with spot check:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Now that you already ran the backfill script, when would you expect us to run it in the future? If it makes sense to commit that file or not.
Since its a back-filler, it's safe to run at any time; so if there is any AWS hiccup, for example, you can come back when that outage is done and run the script and be done, not having to worry about exactly what was missed: "Just fix it please!". |
I'll follow up with a doc PR here presently and add a note in the release instructions. |
The new script was used to successfully backfill all Pants release tag mappings to S3 and the release workflow is fixed to scope its sync to just tags and the underlying helper deploy_to_s3.py code to skip index.html generation when there is no data to generate it from. (cherry picked from commit a837b35)
The new script was used to successfully backfill all Pants release tag mappings to S3 and the release workflow is fixed to scope its sync to just tags and the underlying helper deploy_to_s3.py code to skip index.html generation when there is no data to generate it from. (cherry picked from commit a837b35)
…17808) (#17814) Cherry-pick the new release workflow for mapping release tags to commits. This is 3 stacked cherry-picks, all clean: commit 4841e8b (HEAD -> release_tag_mapping/tools/CPs, origin/release_tag_mapping/tools/CPs) Author: John Sirois <[email protected]> Date: Wed Dec 14 14:18:38 2022 -0800 Document the release tag back-fill script. (#17808) (cherry picked from commit 2dc4c1b) commit bca29f6 Author: John Sirois <[email protected]> Date: Wed Dec 14 13:21:01 2022 -0800 Add a release tag backfill script. (#17806) The new script was used to successfully backfill all Pants release tag mappings to S3 and the release workflow is fixed to scope its sync to just tags and the underlying helper deploy_to_s3.py code to skip index.html generation when there is no data to generate it from. (cherry picked from commit a837b35) commit 2922d74 Author: John Sirois <[email protected]> Date: Wed Dec 14 07:26:53 2022 -0800 Set up release tag mapping workflow. (#17801) This will establish an `https://binaries.pantsbuild.org/tags/pantsbuild.pants/release_*` file for each `release_*` tag pushed. The file will contain the tagged commit's sha for use by `scie-pants` in setting up the proper `--find-links` repo for the purposes of installing that Pants version. After manually running this workflow for a few old release tags, an automated backfill (seperate script forthcoming) will be run. See commentary in pantsbuild/scie-pants#1 (cherry picked from commit 340f736)
…17808) (#17815) Cherry-pick the new release workflow for mapping release tags to commits. This is 3 stacked cherry-picks, all clean: commit 4841e8b (HEAD -> release_tag_mapping/tools/CPs, origin/release_tag_mapping/tools/CPs) Author: John Sirois <[email protected]> Date: Wed Dec 14 14:18:38 2022 -0800 Document the release tag back-fill script. (#17808) (cherry picked from commit 2dc4c1b) commit bca29f6 Author: John Sirois <[email protected]> Date: Wed Dec 14 13:21:01 2022 -0800 Add a release tag backfill script. (#17806) The new script was used to successfully backfill all Pants release tag mappings to S3 and the release workflow is fixed to scope its sync to just tags and the underlying helper deploy_to_s3.py code to skip index.html generation when there is no data to generate it from. (cherry picked from commit a837b35) commit 2922d74 Author: John Sirois <[email protected]> Date: Wed Dec 14 07:26:53 2022 -0800 Set up release tag mapping workflow. (#17801) This will establish an `https://binaries.pantsbuild.org/tags/pantsbuild.pants/release_*` file for each `release_*` tag pushed. The file will contain the tagged commit's sha for use by `scie-pants` in setting up the proper `--find-links` repo for the purposes of installing that Pants version. After manually running this workflow for a few old release tags, an automated backfill (seperate script forthcoming) will be run. See commentary in pantsbuild/scie-pants#1 (cherry picked from commit 340f736)
### Internal * Get rid of `_ToolLockfileMixin`. ([#17823](#17823)) * Fix `build-support/bin/deploy_to_s3.py`. ([#17818](#17818)) * Upgrade setproctitle to 1.3.2 ([#17804](#17804)) * Document the release tag back-fill script. ([#17808](#17808)) * Add a release tag backfill script. ([#17806](#17806)) * Set up release tag mapping workflow. ([#17801](#17801)) * go: fix path lookup for copied header files ([#17798](#17798)) * go: set `replace_sandbox_root_in_args=True` since replacement is used ([#17797](#17797)) * go: set missing `Goal.environment_behavior` on a debug goal ([#17799](#17799)) * go: rename option to --go-test-coverage-packages ([#17795](#17795)) * A stub page for dep validation docs. ([#17788](#17788)) * Upgrade to newest remote execution proto ([#17786](#17786)) * Adding tests for `cc` dependency inference showing source roots as `include_directories` ([#17738](#17738)) * Fix validation of release PEXes. ([#17785](#17785)) * Unconditionally register export-codegen goal in pants.core ([#17782](#17782)) * go: allow exporting cgo codegen for third party packages ([#17770](#17770)) * Properly set `pex_root` when running python sources in-sandbox. ([#17750](#17750)) * Renames `output_files` and `output_directories` fields for `experimental_shell_command` ([#17744](#17744))
The new script was used to successfully backfill all Pants release tag mappings
to S3 and the release workflow is fixed to scope its sync to just tags and the
underlying helper deploy_to_s3.py code to skip index.html generation when there
is no data to generate it from.