Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: set missing Goal.environment_behavior on a debug goal #17799

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Dec 14, 2022

Set environment_behavior for the go-dump-import-path-mapping debug goal.

@tdyas tdyas added backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc. labels Dec 14, 2022
@tdyas
Copy link
Contributor Author

tdyas commented Dec 14, 2022

Fixes this warning:

03:28:03.03 [WARN] DEPRECATED: Setting `Goal.environment_behavior=EnvironmentBehavior.UNMIGRATED` for `Goal` `go-dump-import-path-mapping` is scheduled to be removed in version 2.17.0.dev0.

@tdyas tdyas merged commit e16c7d8 into pantsbuild:main Dec 14, 2022
@tdyas tdyas deleted the golang_set_env_behavior branch December 14, 2022 08:05
@stuhood stuhood mentioned this pull request Dec 17, 2022
stuhood added a commit that referenced this pull request Dec 17, 2022
### Internal

* Get rid of `_ToolLockfileMixin`. ([#17823](#17823))

* Fix `build-support/bin/deploy_to_s3.py`. ([#17818](#17818))

* Upgrade setproctitle to 1.3.2 ([#17804](#17804))

* Document the release tag back-fill script. ([#17808](#17808))

* Add a release tag backfill script. ([#17806](#17806))

* Set up release tag mapping workflow. ([#17801](#17801))

* go: fix path lookup for copied header files ([#17798](#17798))

* go: set `replace_sandbox_root_in_args=True` since replacement is used ([#17797](#17797))

* go: set missing `Goal.environment_behavior` on a debug goal ([#17799](#17799))

* go: rename option to --go-test-coverage-packages ([#17795](#17795))

* A stub page for dep validation docs. ([#17788](#17788))

* Upgrade to newest remote execution proto ([#17786](#17786))

* Adding tests for `cc` dependency inference showing source roots as `include_directories` ([#17738](#17738))

* Fix validation of release PEXes. ([#17785](#17785))

* Unconditionally register export-codegen goal in pants.core ([#17782](#17782))

* go: allow exporting cgo codegen for third party packages ([#17770](#17770))

* Properly set `pex_root` when running python sources in-sandbox. ([#17750](#17750))

* Renames `output_files` and `output_directories` fields for `experimental_shell_command` ([#17744](#17744))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants