go: allow exporting cgo codegen for third party packages #17770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
added
backend: Go
benjyw
approved these changes
Dec 10, 2022
|
In the future could |
Maybe? Also is |
Merged
stuhood
added a commit
that referenced
this pull request
Dec 17, 2022
### Internal * Get rid of `_ToolLockfileMixin`. ([#17823](#17823)) * Fix `build-support/bin/deploy_to_s3.py`. ([#17818](#17818)) * Upgrade setproctitle to 1.3.2 ([#17804](#17804)) * Document the release tag back-fill script. ([#17808](#17808)) * Add a release tag backfill script. ([#17806](#17806)) * Set up release tag mapping workflow. ([#17801](#17801)) * go: fix path lookup for copied header files ([#17798](#17798)) * go: set `replace_sandbox_root_in_args=True` since replacement is used ([#17797](#17797)) * go: set missing `Goal.environment_behavior` on a debug goal ([#17799](#17799)) * go: rename option to --go-test-coverage-packages ([#17795](#17795)) * A stub page for dep validation docs. ([#17788](#17788)) * Upgrade to newest remote execution proto ([#17786](#17786)) * Adding tests for `cc` dependency inference showing source roots as `include_directories` ([#17738](#17738)) * Fix validation of release PEXes. ([#17785](#17785)) * Unconditionally register export-codegen goal in pants.core ([#17782](#17782)) * go: allow exporting cgo codegen for third party packages ([#17770](#17770)) * Properly set `pex_root` when running python sources in-sandbox. ([#17750](#17750)) * Renames `output_files` and `output_directories` fields for `experimental_shell_command` ([#17744](#17744))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go-export-cgo-codegendebug goal was unnecessarily limited to exporting just Cgo codegen for first-partygo_packagetargets. As part of fixing #17592, it is useful to also be able to dump Cgo codegen for any third-party packages using Cgo. This PR teachesgo-export-cgo-codegenhow to do that.