Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up release tag mapping workflow. #17801

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Set up release tag mapping workflow. #17801

merged 3 commits into from
Dec 14, 2022

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Dec 14, 2022 •
edited
Loading

This will establish an
https://binaries.pantsbuild.org/tags/pantsbuild.pants/release_* file
for each release_* tag pushed. The file will contain the tagged
commit's sha for use by scie-pants in setting up the proper
--find-links repo for the purposes of installing that Pants version.

After manually running this workflow for a few old release tags, an
automated backfill (seperate script forthcoming) will be run.

See commentary in pantsbuild/scie-pants#1

@jsirois
Set up release tag mapping workflow.
07f183e 
This will establish an
`https://binaries.pantsbuild.org/tags/pantsbuild.pants/release_*` file
for each `release_*` tag pushed. The file will contain the tagged
commit's sha for use by `scie-pants` in setting up the proper
`--find-links` repo for the purposes of installing that Pants version.

After manually running this workflow for a few old release tags, an
automated backfill (seperate script forthcoming) will be run.
@jsirois jsirois added the category:internal CI, fixes for not-yet-released features, etc. label Dec 14, 2022
jsirois
jsirois commented Dec 14, 2022
View reviewed changes
build-support/bin/generate_github_workflows.py
"publish-tag-to-commit-mapping": {
"runs-on": "ubuntu-latest",
"if": IS_PANTS_OWNER,
"steps": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use these 1st two steps in Pex, the a-scie projects and several other pantsbuild projects. Pretty well tested.

@jsirois jsirois mentioned this pull request Dec 14, 2022
Merged
benjyw
benjyw approved these changes Dec 14, 2022
View reviewed changes
build-support/bin/generate_github_workflows.py Outdated
},
{
"name": "Create Release -> Commit Mapping",
# N.B.: The "literal suffix" mentioned below will only be the actual correct
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I found this note more confusing than clarifying. Maybe the comment below (the sentence after "Tricky syntax, but correct.") can use single braces (and link to https://git-scm.com/docs/git-rev-parse#Documentation/git-rev-parse.txt-emltrevgtlttypegtemegemv0998commitem ?)

The reader will understand that the double braces are for escaping .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, dammit, the double-braces are needed in the comment so that it renders in the yaml comment. I see what you were doing with the code comment... I still found it confusing at first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can all be a code comment? We don't render yaml comments anywhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds good - lifted the comment out of the yaml.

@jsirois jsirois merged commit 340f736 into pantsbuild:main Dec 14, 2022
@jsirois jsirois deleted the pants_version/S3/backfill branch December 14, 2022 15:26
@jsirois jsirois mentioned this pull request Dec 14, 2022
Closed
jsirois added a commit to jsirois/pants that referenced this pull request Dec 15, 2022
@jsirois
Set up release tag mapping workflow. (pantsbuild#17801)
2922d74 
This will establish an
`https://binaries.pantsbuild.org/tags/pantsbuild.pants/release_*` file
for each `release_*` tag pushed. The file will contain the tagged
commit's sha for use by `scie-pants` in setting up the proper
`--find-links` repo for the purposes of installing that Pants version.

After manually running this workflow for a few old release tags, an
automated backfill (seperate script forthcoming) will be run.

See commentary in pantsbuild/scie-pants#1

(cherry picked from commit 340f736)
jsirois added a commit to jsirois/pants that referenced this pull request Dec 15, 2022
@jsirois
Set up release tag mapping workflow. (pantsbuild#17801)
c5151b0 
This will establish an
`https://binaries.pantsbuild.org/tags/pantsbuild.pants/release_*` file
for each `release_*` tag pushed. The file will contain the tagged
commit's sha for use by `scie-pants` in setting up the proper
`--find-links` repo for the purposes of installing that Pants version.

After manually running this workflow for a few old release tags, an
automated backfill (seperate script forthcoming) will be run.

See commentary in pantsbuild/scie-pants#1

(cherry picked from commit 340f736)
jsirois added a commit that referenced this pull request Dec 15, 2022
@jsirois
Set up release tag mapping workflow. (Cherry-pick of #17801, #17806 & #…
6659ff6 
…17808) (#17814)

Cherry-pick the new release workflow for mapping release tags to commits.

This is 3 stacked cherry-picks, all clean:

commit 4841e8b (HEAD -> release_tag_mapping/tools/CPs, origin/release_tag_mapping/tools/CPs)
Author: John Sirois <[email protected]>
Date:   Wed Dec 14 14:18:38 2022 -0800

    Document the release tag back-fill script. (#17808)

    (cherry picked from commit 2dc4c1b)

commit bca29f6
Author: John Sirois <[email protected]>
Date:   Wed Dec 14 13:21:01 2022 -0800

    Add a release tag backfill script. (#17806)

    The new script was used to successfully backfill all Pants release tag mappings
    to S3 and the release workflow is fixed to scope its sync to just tags and the
    underlying helper deploy_to_s3.py code to skip index.html generation when there
    is no data to generate it from.

    (cherry picked from commit a837b35)

commit 2922d74
Author: John Sirois <[email protected]>
Date:   Wed Dec 14 07:26:53 2022 -0800

    Set up release tag mapping workflow. (#17801)

    This will establish an
    `https://binaries.pantsbuild.org/tags/pantsbuild.pants/release_*` file
    for each `release_*` tag pushed. The file will contain the tagged
    commit's sha for use by `scie-pants` in setting up the proper
    `--find-links` repo for the purposes of installing that Pants version.

    After manually running this workflow for a few old release tags, an
    automated backfill (seperate script forthcoming) will be run.

    See commentary in pantsbuild/scie-pants#1

    (cherry picked from commit 340f736)
jsirois added a commit that referenced this pull request Dec 15, 2022
@jsirois
Set up release tag mapping workflow. (Cherry-pick of #17801, #17806 & #…
ce791e6 
…17808) (#17815)

Cherry-pick the new release workflow for mapping release tags to commits.

This is 3 stacked cherry-picks, all clean:

commit 4841e8b (HEAD -> release_tag_mapping/tools/CPs, origin/release_tag_mapping/tools/CPs)
Author: John Sirois <[email protected]>
Date:   Wed Dec 14 14:18:38 2022 -0800

    Document the release tag back-fill script. (#17808)

    (cherry picked from commit 2dc4c1b)

commit bca29f6
Author: John Sirois <[email protected]>
Date:   Wed Dec 14 13:21:01 2022 -0800

    Add a release tag backfill script. (#17806)

    The new script was used to successfully backfill all Pants release tag mappings
    to S3 and the release workflow is fixed to scope its sync to just tags and the
    underlying helper deploy_to_s3.py code to skip index.html generation when there
    is no data to generate it from.

    (cherry picked from commit a837b35)

commit 2922d74
Author: John Sirois <[email protected]>
Date:   Wed Dec 14 07:26:53 2022 -0800

    Set up release tag mapping workflow. (#17801)

    This will establish an
    `https://binaries.pantsbuild.org/tags/pantsbuild.pants/release_*` file
    for each `release_*` tag pushed. The file will contain the tagged
    commit's sha for use by `scie-pants` in setting up the proper
    `--find-links` repo for the purposes of installing that Pants version.

    After manually running this workflow for a few old release tags, an
    automated backfill (seperate script forthcoming) will be run.

    See commentary in pantsbuild/scie-pants#1

    (cherry picked from commit 340f736)
@stuhood stuhood mentioned this pull request Dec 17, 2022
Merged
stuhood added a commit that referenced this pull request Dec 17, 2022
@stuhood
Prepare 2.16.0.dev3 (#17831)
dc24347 
### Internal

* Get rid of `_ToolLockfileMixin`. ([#17823](#17823))

* Fix `build-support/bin/deploy_to_s3.py`. ([#17818](#17818))

* Upgrade setproctitle to 1.3.2 ([#17804](#17804))

* Document the release tag back-fill script. ([#17808](#17808))

* Add a release tag backfill script. ([#17806](#17806))

* Set up release tag mapping workflow. ([#17801](#17801))

* go: fix path lookup for copied header files ([#17798](#17798))

* go: set `replace_sandbox_root_in_args=True` since replacement is used ([#17797](#17797))

* go: set missing `Goal.environment_behavior` on a debug goal ([#17799](#17799))

* go: rename option to --go-test-coverage-packages ([#17795](#17795))

* A stub page for dep validation docs. ([#17788](#17788))

* Upgrade to newest remote execution proto ([#17786](#17786))

* Adding tests for `cc` dependency inference showing source roots as `include_directories` ([#17738](#17738))

* Fix validation of release PEXes. ([#17785](#17785))

* Unconditionally register export-codegen goal in pants.core ([#17782](#17782))

* go: allow exporting cgo codegen for third party packages ([#17770](#17770))

* Properly set `pex_root` when running python sources in-sandbox. ([#17750](#17750))

* Renames `output_files` and `output_directories` fields for `experimental_shell_command` ([#17744](#17744))
This was referenced Dec 30, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@stuhood stuhood Awaiting requested review from stuhood

@chrisjrn chrisjrn Awaiting requested review from chrisjrn

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirois @benjyw