Merge apache 20200122a #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add toast presenter * Improve message when unauthenticated * Lint
* move cypress into it's own directory with package.json * update contributing and include cypress fixtures dir * newline * fix rebase * add cypress dep * bump cypress
* refactor dashboard and slice models * appease various linters * remove shortcuts & import indirection * appease mypy * fix bad imports * lint * address various issues * ignore type issue * remove unused imports * lint
…e original query parameter (apache#8835) * [explore view] fix: Inline edit chart title cause unintended overwrite original query parameter * add more unit tests * handle new slice case
…pache#8857) * separators removed, "childs" changed to "children" * changing `children` back to `childs`... it's baked in somewhere in Fab * linting * reverting changes to MenuObject * adding separator above Druid menu items
* moving favicon to config, allowing multiple favicons * black...
* Add type annotations and fix inconsistencies * Address review comments * Remove incorrect typing of jsonable obj
* Enable running of tests in tests/db_engine_specs * Resolve application context errors * Refactor and add tests for pyodbc.Row conversion * Appease isort, regardless of isort:skip
* Add new entry to lists of users of Apache Superset Add new entry to lists of users of Apache Superset * Alphabetical order Alphabetical order
…pache#8733) * Use PyArrow Table for query result serialization * Cleanup dev comments * Additional cleanup * WIP: tests * Remove explicit dtype logic from db_engine_specs * Remove obsolete column property * SupersetTable column types * Port SupersetDataFrame methods to SupersetTable * Add test for nullable boolean columns * Support datetime values with timezone offsets * Black formatting * Pylint * More linting/formatting * Resolve issue with timezones not appearing in results * Types * Enable running of tests in tests/db_engine_specs * Resolve application context errors * Refactor and add tests for pyodbc.Row conversion * Appease isort, regardless of isort:skip * Re-enable RESULTS_BACKEND_USE_MSGPACK default based on benchmarks * Dataframe typing and nits * Renames to reduce ambiguity
- Replace ldap with LDAP - Replace `(username/password()` with `(username/password)`
* Moving appbuilder.xxx out of view files ands into app.py * Pulled url map converters out into their own file * Adding license blurb * Linting * Linting again...
* [dashboards] Fix, missing mulexport permission * [dashboards] Fix, missing mulexport permission
* Added spec for Dremio * Installation instructions for Dremio * added dependency for dremio * Update dremio.py * ASF header, dttm, set min version in setup.py * Update installation.rst * Update installation.rst * fix tox 'Title underline too short.' * change URI example Co-authored-by: Naren <[email protected]>
…CSS tweaks (apache#8781) * Bumping less-loader * moving/updating styles, with a bit of linting as I go. * more whittling * caught a couple more colors * reverting plugin config changes I was hacking around with. * toast messages now use status colors across the board. * no more pink. * expanding scope of linting * a little more CSS linting * fixing popover adhoc metric title height issue * eslint: Ignoring nore modules in subfolders
…pache#8576) * [db migration] change datasources foreign key to cluster_id * address pr comments * address pr comment, fix ci
* docs: add Reward Gateway to README corrects apache#8533 * Update README.md Removed trailing whitespace. Co-authored-by: John Bodley <[email protected]>
…#8876) * wip * wip * wip * modal to update dashboard properties * cleanup * translations and flavor text * linted * more explanatory text in the modal
this has been bugging me
* [dashboards] Multiple exports * [dashboards] Fix, mulexport permission missing * [dashboards] Test for security filtered export * [dashboards] Address PR comments
* adds dashboard listview component * use new api * use json over rison * lint * adds seperate dashboard list view * edit and delete actions * fix lint ignore * fix common_bootstrap_payload is now a function * fix license * fix pylint * isort * fix tests * lint * lint ts * fix js tests * fix double import from bad rebase * fix indent error * lookup permissions * generic permission lookup * get tslint to pass * adds js specs * lint * fix rebase * lint * lint again * fix type errors preventing build * adds more specs * fix tslint error * fix null check * remove unecessary code * use translations provided by api * more translations * linting * fix spec * i18n * fix register order
* Add datasource.changed_on to cache_key and add+fix related unit tests * Add note to UPDATING.md * Remove redundant comment about metric names
) * [sip-15] Displaying endpoints for all start/end time ranges * Update superset/assets/src/explore/components/controls/DateFilterControl.jsx Co-Authored-By: Erik Ritter <[email protected]> * Update superset/assets/src/explore/components/controls/DateFilterControl.jsx Co-Authored-By: Erik Ritter <[email protected]> * Update DateFilterControl.jsx Co-authored-by: Erik Ritter <[email protected]>
* [charts] New REST API * [charts] Small improvements * [charts] Fix, lint * [charts] Tests and datasource validation * [charts] Fix, lint * [charts] DRY post schemas * [charts] lint and improve type declarations * [charts] DRY owned REST APIs * [charts] Small fixes * [charts] More tests * [charts] Tests and DRY * [charts] Tests for update * [charts] More tests * [charts] Fix, isort * [charts] DRY and improve quality * [charts] DRY and more tests * [charts] Refactor base for api and schemas * [charts] Fix bug on partial updates for dashboards * [charts] Fix missing apache license * black app.py after merge * [charts] Fix, missing imports and black * [api] Log on sqlalchemy error * [api] isort
* [dashboards] New, API for Bulk delete * [dashboards] Tests * [dashboards] Fix not found on multiple delete * [dashboards] Bulk delete partial deletes on not owned dashes * [dashboards] Improve OpenAPI spec and tests * [dashboards] Test for bad request * [dashboards] i18n * [dashboards] black * [dashboard] make bulk all or nothing * [dashboard] Log on sqlalchemy error * [dashboard] Log on sqlalchemy error
* Bump pandas to 0.25.3 as per recommendation to get ready for 1.0 * Localize timezone aware Pandas series prior to Arrow conversion
|
Out of curiosity, which file(s) required a bit of refactoring or updating. Was it painful? Should we be concerned about this happening again? Do we have a game plan for tags? (Sorry for the many questions :) |
|
There was a test failing due to props not being in scope, I fixed it with |
…perset into merge_apache_20200122a
It was The file was refactored changing I don't think it will happen again so soon, and I want to work on the tagging frontend when I have time. I actually wrote a PR, but by the time it was accepted a lot of stuff had been refactored and the reviewer asked me to do it the new way, and I just dropped it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Apache
masterinto Lyftapache-master.👀 @DiggidyDave @khtruong