[explore view] fix: Inline edit chart title cause unintended overwrite original query parameter #8835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e original query parameter
graceguo-supercat
force-pushed
the
gg-FixInlineEditSliceName
branch
from
0a3b74e to
253c7d9
Compare
suddjian
reviewed
Dec 18, 2019
| }); | ||
| // this.props.slice hold the original slice params stored in slices table | ||
| this.props.actions | ||
| .saveSlice(this.props.slice.form_data, params) |
There was a problem hiding this comment.
If I'm understanding the code above this correctly, this will fail on a new slice. But it looks like the new slice case is tested, so maybe the isNewSlice code isn't necessary?
There was a problem hiding this comment.
@suddjian Thanks so much for catching the new slice case! i fixed it and added unit test.
Codecov Report
@@ Coverage Diff @@
## master #8835 +/- ##
==========================================
+ Coverage 58.73% 58.97% +0.24%
==========================================
Files 359 359
Lines 11324 11333 +9
Branches 2779 2787 +8
==========================================
+ Hits 6651 6684 +33
+ Misses 4495 4471 -24
Partials 178 178
Continue to review full report at Codecov.
|
suddjian
approved these changes
Dec 18, 2019
michellethomas
approved these changes
Dec 19, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
To reproduce this issue:
Note
reload and redirectbehavior.Expected behavior:
inline edit chart title should only overwrite chart title, should not change original chart with unsaved query parameters.
TEST PLAN
CI and manual test
REVIEWERS
@etr2460 @michellethomas @mistercrunch