Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] fix for empty dashboard slug when editing #8974

Merged
merged 1 commit into from
Jan 16, 2020
Merged

[dashboard] fix for empty dashboard slug when editing #8974

merged 1 commit into from
Jan 16, 2020

Conversation

suddjian
Copy link
Member

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Needed to check if there was a slug before pushing a new url

ADDITIONAL INFORMATION

REVIEWERS

@graceguo-supercat

@mistercrunch
Copy link
Member

closes #8968

@mistercrunch mistercrunch merged commit 7e67190 into apache:master Jan 16, 2020
@suddjian suddjian deleted the fix/dashboard-empty-slug branch January 16, 2020 17:29
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suddjian @mistercrunch