fix empty slug breaking url (#8974)

apache · Jan 16, 2020 · 7e67190 · 7e67190
1 parent ff9bc74
commit 7e67190
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/superset/assets/src/dashboard/components/Header.jsx b/superset/assets/src/dashboard/components/Header.jsx
@@ -431,11 +431,13 @@ class Header extends React.PureComponent {
                   metadata: JSON.parse(updates.jsonMetadata),
                 });
                 this.props.dashboardTitleChanged(updates.title);
-                history.pushState(
-                  { event: 'dashboard_properties_changed' },
-                  '',
-                  `/superset/dashboard/${updates.slug}/`,
-                );
+                if (updates.slug) {
+                  history.pushState(
+                    { event: 'dashboard_properties_changed' },
+                    '',
+                    `/superset/dashboard/${updates.slug}/`,
+                  );
+                }
               }}
             />
           )}

diff --git a/superset/assets/src/dashboard/components/PropertiesModal.jsx b/superset/assets/src/dashboard/components/PropertiesModal.jsx
@@ -52,10 +52,10 @@ class PropertiesModal extends React.PureComponent {
     this.state = {
       errors: [],
       values: {
-        dashboard_title: this.props.dashboardTitle,
-        slug: this.props.dashboardInfo.slug,
-        owners: this.props.owners || [],
-        json_metadata: JSON.stringify(this.props.dashboardInfo.metadata),
+        dashboard_title: props.dashboardTitle,
+        slug: props.dashboardInfo.slug,
+        owners: props.owners || [],
+        json_metadata: JSON.stringify(props.dashboardInfo.metadata),
       },
       isOwnersLoaded: false,
       userOptions: null,
@@ -189,7 +189,7 @@ class PropertiesModal extends React.PureComponent {
                   name="slug"
                   type="text"
                   bsSize="sm"
-                  value={values.slug}
+                  value={values.slug || ''}
                   onChange={this.onChange}
                 />
                 <p className="help-block">