Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out DatasourceAccessRequest model #8809

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

suddjian
Copy link
Member

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Part of a multi-part refactoring effort, more PRs incoming

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot. Thanks for breaking this up.

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #8809 into master will increase coverage by 0.32%.
The diff coverage is 57.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8809      +/-   ##
==========================================
+ Coverage    65.9%   66.22%   +0.32%     
==========================================
  Files         483      484       +1     
  Lines       24165    24507     +342     
  Branches     2770     2770              
==========================================
+ Hits        15926    16230     +304     
- Misses       8061     8099      +38     
  Partials      178      178
Impacted Files Coverage Δ
superset/models/core.py 85.58% <ø> (+2.48%) ⬆️
superset/models/__init__.py 100% <100%> (ø) ⬆️
superset/views/core.py 72.15% <100%> (+0.01%) ⬆️
superset/models/datasource_access_request.py 55.35% <55.35%> (ø)
superset/views/log/views.py 100% <0%> (ø) ⬆️
superset/exceptions.py 100% <0%> (ø) ⬆️
superset/sql_parse.py 97.74% <0%> (+1.61%) ⬆️
superset/views/base.py 77.35% <0%> (+2.61%) ⬆️
superset/translations/utils.py 90.9% <0%> (+3.4%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60914fa...c0ef8d5. Read the comment docs.

@mistercrunch
Copy link
Member

celery

@mistercrunch mistercrunch merged commit 7a68cb7 into apache:master Dec 18, 2019
@suddjian suddjian deleted the refactor-dar branch December 18, 2019 08:37
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants