Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filter_box] Fix ; separated filter_box default values #8949

Merged
merged 1 commit into from
Jan 14, 2020
Merged

[filter_box] Fix ; separated filter_box default values #8949

merged 1 commit into from
Jan 14, 2020

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jan 11, 2020 •
edited
Loading

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Superset allow user set multi values for filter field default value, separated by ;:
Screen Shot 2020-01-11 at 3 20 27 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2020-01-11 at 3 21 08 PM

After:
Screen Shot 2020-01-11 at 3 20 35 PM

TEST PLAN

new unit test is created.

ADDITIONAL INFORMATION

REVIEWERS

@michellethomas @etr2460

@graceguo-supercat graceguo-supercat force-pushed the gg-FixDefaultFiltersForDashboard branch 2 times, most recently from d4bb350 to d3d3924 Compare January 11, 2020 07:37
@graceguo-supercat graceguo-supercat force-pushed the gg-FixDefaultFiltersForDashboard branch from d3d3924 to c6fc281 Compare January 11, 2020 23:02
etr2460
etr2460 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming the one behavior change is ok

superset/assets/src/dashboard/util/getFilterConfigsFromFormdata.js Show resolved Hide resolved
@graceguo-supercat graceguo-supercat merged commit 50f21cb into apache:master Jan 14, 2020
@graceguo-supercat graceguo-supercat deleted the gg-FixDefaultFiltersForDashboard branch February 10, 2020 04:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graceguo-supercat @etr2460 @mistercrunch