Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy using private registry #847

Merged
merged 25 commits into from
Feb 21, 2019
Merged

Deploy using private registry #847

merged 25 commits into from
Feb 21, 2019

Conversation

bvennam
Copy link
Contributor

@bvennam bvennam commented Jan 30, 2019

Fixes #819

Proposed Changes

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2019
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Jan 30, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2019
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jan 30, 2019
samodell
samodell suggested changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@samodell samodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, but this is looking good! Thanks for taking the time to right this up.

One other point -- we should link to this guide from within the documentation somewhere, so it's not buried. The READMEs for each folder have been behaving as lists of the content within that folder. You might need to create a new category for this link on the /serving/README.md, I'm not sure it fits with the existing ones. But feel free to disagree!

samodell and others added 12 commits February 20, 2019 11:07
@bvennam
Copy link
Contributor Author

bvennam commented Feb 20, 2019

@samodell Thank you for taking the time to provide this feedback! This should be ready to review again.

gyliu513
gyliu513 reviewed Feb 21, 2019
View reviewed changes
samodell
samodell reviewed Feb 21, 2019
View reviewed changes
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: beemarie, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell
Copy link
Contributor

/ok-to-test
/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2019
@knative-prow-robot knative-prow-robot merged commit 479d8f8 into knative:master Feb 21, 2019
samodell pushed a commit to samodell/docs that referenced this pull request Feb 27, 2019
@bvennam @samodell
Deploy using private registry (knative#847)
8e6a733 
* new doc for deploying with private registry

* update last few steps

* header sizes

* capitalization

* updating with correct registry annotation and small edits

* wording

* formatting

* formatting

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* update based on feedback

* missing <

* adding tic marks for filename

* udpate with helloworld-go sample

* add testing application

* update return from helloworld app

* update readme with link to doc

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>
knative-prow-robot pushed a commit that referenced this pull request Feb 27, 2019
@samodell @knative-prow-robot
adding frontmatter; cherry-picking commit into 0.3 (#943)
86b783b 
* Deploy using private registry (#847)

* new doc for deploying with private registry

* update last few steps

* header sizes

* capitalization

* updating with correct registry annotation and small edits

* wording

* formatting

* formatting

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* update based on feedback

* missing <

* adding tic marks for filename

* udpate with helloworld-go sample

* add testing application

* update return from helloworld app

* update readme with link to doc

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* adding frontmatter; cherry-picking commit into 0.3
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 19, 2019
@samodell @RichieEscarez
adding frontmatter; cherry-picking commit into 0.3 (knative#943)
962154a 
* Deploy using private registry (knative#847)

* new doc for deploying with private registry

* update last few steps

* header sizes

* capitalization

* updating with correct registry annotation and small edits

* wording

* formatting

* formatting

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* update based on feedback

* missing <

* adding tic marks for filename

* udpate with helloworld-go sample

* add testing application

* update return from helloworld app

* update readme with link to doc

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* adding frontmatter; cherry-picking commit into 0.3
knative-prow-robot pushed a commit that referenced this pull request Mar 20, 2019
@RichieEscarez @knative-prow-robot
Merge website files into Master (#1025)
3c04f86 
* Add front matter to Build files (#833)

* Update README.md

* Adding front matter to builds.md

* Update installing-build-component.md

* Update README.md

Revert changes so Richie can handle this with the index file

* Update builder-contract.md

* Update personas.md

* Update auth.md

* Update creating-builds.md

* Update build-templates.md

* sentence case

* sentence case

* sentence case

* Adding frontmatter to /install/ (#834)

* Adds front matter to Serving (#838)

* Update accessing-logs.md

* Update accessing-metrics.md

* Update accessing-traces.md

* Update cluster-local-route.md

* Update debugging-application-issues.md

* Update debugging-performance-issues.md

* Update gke-assigning-static-ip-address.md

* Update installing-logging-metrics-traces.md

* Update outbound-network-access.md

* Update setting-up-a-logging-plugin.md

* Update using-a-custom-domain.md

* Update using-an-ssl-cert.md

* Update using-cert-manager-on-gcp.md

* Update using-external-dns-on-gcp.md

* site index for fluentd folder (#839)

* add Hugo index files and frontmatter (#840)

* hugo build files for autogen refdocs (#841)

* move resources and readme (#843)

* site: add blog (#837)

* add blog folder

* switch to sentence case

* site: add community and contributing (#836)

* add _index.md files and front matter

* switch to sentance case caps

* fix weights

* Update community/samples/README.md

Co-Authored-By: RichieEscarez <[email protected]>

* site: restructure content into a "docs" directory (#842)

* move content into a 'docs' directory

* inject additional 'docs' directory

* site: add build files and front matter to serving samples (#850)

* new _index.md files and front matter

* serving samples + fix urls

* remove file

* add PR#851 - channels (#853)

* Update README.md (#854)

* Remove README.md from all links (#855)

* Remove README.md from all links

* mend

* mend

* mend

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* fix links in community (#857)

* Update _index.md (#856)

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

Adds missing pointer to README

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* revert

* fix build links (#858)

* site: fix eventing links (#859)

* fix eventing links

* Update README.md

* fix install links (#860)

* site: fix serving links (#861)

* fix serving links

* Update using-external-dns-on-gcp.md

* remove hardcoded github link (#863)

* Update README.md (#864)

Fix links by removing md file extensions.

* Fix links (#866)

* Fix links

* Update installing-build-component.md

* Update builder-contract.md

* add missing hello-world directory (#865)

* Link fixes for Build (#867)

* Fix links

* Update installing-build-component.md

* Update builder-contract.md

* Update creating-builds.md

* Update builder-contract.md

* Update builds.md

* Update creating-builds.md

* Update installing-build-component.md

* Update installing-build-component.md

* Update creating-builds.md

* Update creating-builds.md

* Update builds.md

* Update build-templates.md

* convert to Hugo rel link

* Manually run prettier.io (#880)

* Manually run prettier.io

Trying to fix the stuff that hits prettier.io bugs.

* Fix prettier.io issues.

* Revert manual link fixes (use new build script instead) (#927)

* Revert "convert to Hugo rel link"

This reverts commit f1bbc8e.

* Revert "Fix links (#866)"

This reverts commit 3a57ffe.

* Revert "remove hardcoded github link (#863)"

This reverts commit fb7fdd9.

* Revert "site: fix serving links (#861)"

This reverts commit f61514c.

* Revert "fix install links (#860)"

This reverts commit 1fcf32b.

* Revert "site: fix eventing links (#859)"

This reverts commit 8809165.

* Revert "fix build links (#858)"

This reverts commit 847e08b.

* Revert "fix links in community (#857)"

This reverts commit 0cd5a44.

* Revert "Remove README.md from all links (#855)"

This reverts commit 2029c8b.

* Revert "Update README.md (#864)"

This reverts commit 072c731.

* Adding frontmatter to Gloo guide (#939)

*  adding frontmatter; cherry-picking commit into 0.3 (#943)

* Deploy using private registry (#847)

* new doc for deploying with private registry

* update last few steps

* header sizes

* capitalization

* updating with correct registry annotation and small edits

* wording

* formatting

* formatting

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* update based on feedback

* missing <

* adding tic marks for filename

* udpate with helloworld-go sample

* add testing application

* update return from helloworld app

* update readme with link to doc

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* adding frontmatter; cherry-picking commit into 0.3

* Update Knative-with-Minishift.md (#988)

Update to correct title (Openshift > Minishift), as mentioned by Ashleigh in the Docs WG.

* add type:docs + enable relative links (#990)

* Deleting an unnecessary file

accidentally copied in extra file

* update ref docs api build script and files (#997)

* all links must have ./ (#1004)

* all links must have ./

* Update contributing/README.md

Co-Authored-By: RichieEscarez <[email protected]>

* Update contributing/README.md

Co-Authored-By: RichieEscarez <[email protected]>

* Update for clarity

* Update README.md

Fixing my poorly formatting suggestion

* ref tool steps + script (#1008)

* Incorporate edits from #1008 (#1010)

* Incorporate edits from #1008

* Add "contributor" info link

* page-by-page link check fixes (#1024)

* update readmes - source and site versions

* rename file to fix left nav

* rename file and remove folder to fix left nav
@ahmetb ahmetb mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyliu513 gyliu513 gyliu513 left review comments

@samodell samodell samodell approved these changes

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

Assignees

@samodell samodell

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bvennam @googlebot @knative-prow-robot @samodell @gyliu513