Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find old documentation pages about using private registries #2025

Closed
ahmetb opened this issue Dec 5, 2019 · 6 comments
Closed

Can't find old documentation pages about using private registries #2025

ahmetb opened this issue Dec 5, 2019 · 6 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Dec 5, 2019

These pages showing up on site search results for keyword "private" seem to be gone and redirect to the homepage :( (why can't we set up redirect while shuffling files like this in Netlify?)

There's nothing under Serving Component on the sidebar that helps me find where this content has gone to.

image

@ahmetb
Copy link
Contributor Author

ahmetb commented Dec 5, 2019

Sadly all google search results are broken, too. The content at #847 seems to be gone from the site.

image

@RichieEscarez
Copy link
Contributor

Thanks for surfacing the 404s from search results. To combat these SEO challenges, we need to add those URLs into the destination/target file.

This covers at a high-level, how to add the aliases element to the frontmatter of a file to get the desired "redirect" behavior when files move or get deleted:
#1925

@RichieEscarez RichieEscarez added kind/bug Categorizes issue or PR as related to a bug. kind/enhancement kind/good-first-issue Denotes an issue ready for a new contributor. labels Jan 7, 2020
@RichieEscarez RichieEscarez self-assigned this Jan 7, 2020
@RichieEscarez
Copy link
Contributor

Re: #847

That content uses Knative Build, which was deprecated. To view that file, you can view the past doc versions in the GitHub repo (along with the deprecated Knative Build content):

https://github.com/knative/docs/branches/all

@RichieEscarez
Copy link
Contributor

Good news is that I'm not able to get those same search results (likely since our site index was updated and scraped between now and when this issue was opened):

image

The new version of "how to ... private registry" file (from #2027) now shows at the top so im going to close this and also ensure that we are more strict about using "redirects".

Thanks @ahmetb!

@ahmetb
Copy link
Contributor Author

ahmetb commented Jan 7, 2020

I'm seeing no results from knative.dev yet but I'll take your word for it.

image

@RichieEscarez
Copy link
Contributor

RichieEscarez commented Jan 8, 2020

Maybe a chrome history "thing" so I see recently visited pages that match the search query?

I was trying to replicate that query from your screenshot so that I could obtain those URLs that result in 404s and then add them as aliases in the new file. Feel free to pass along any other bad URLs that you come across and i'll happily add them to the frontmatter of current source files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.
Projects
None yet
Development

No branches or pull requests

2 participants