Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge website files into Master #1025

Merged
merged 46 commits into from
Mar 20, 2019
Merged

Merge website files into Master #1025

merged 46 commits into from
Mar 20, 2019

Conversation

RichieEscarez
Copy link
Contributor

@RichieEscarez RichieEscarez commented Mar 19, 2019 •
edited
Loading

Merging all the changes from the website testing and enablement in the release-03 branch, back into master.

This is the first step to enabling the master branch to render in the website (will immediately cut 0.4 (release-0.4) and then add all versions to the doc build so they all appear in the website: knative.dev/docs).

fixes #724 , fixes #725 , fixes #726 , fixes #727 , fixes #728 , fixes #729 , fixes #730

Staged content

These files have been staged here:
https://deploy-preview-12--knative.netlify.com/docs/
Note: View staged content only under ../docs/ (there are still some todos for the staging site so these have been manually built only in that part of the site). Also, keep in mind that main menu links are hard codes and will bring you out of staging, to knative.dev

Next steps

Website open action items: https://github.com/knative/docs/projects/5

@RichieEscarez RichieEscarez added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 19, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Mar 19, 2019
@RichieEscarez RichieEscarez added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed approved labels Mar 19, 2019
carieshmarie and others added 14 commits March 19, 2019 10:38
@carieshmarie @RichieEscarez
Add front matter to Build files (knative#833)
2d747d7 
* Update README.md

* Adding front matter to builds.md

* Update installing-build-component.md

* Update README.md

Revert changes so Richie can handle this with the index file

* Update builder-contract.md

* Update personas.md

* Update auth.md

* Update creating-builds.md

* Update build-templates.md

* sentence case

* sentence case

* sentence case
@samodell @RichieEscarez
Adding frontmatter to /install/ (knative#834)
5cfbd90
@carieshmarie @RichieEscarez
Adds front matter to Serving (knative#838)
781ed46 
* Update accessing-logs.md

* Update accessing-metrics.md

* Update accessing-traces.md

* Update cluster-local-route.md

* Update debugging-application-issues.md

* Update debugging-performance-issues.md

* Update gke-assigning-static-ip-address.md

* Update installing-logging-metrics-traces.md

* Update outbound-network-access.md

* Update setting-up-a-logging-plugin.md

* Update using-a-custom-domain.md

* Update using-an-ssl-cert.md

* Update using-cert-manager-on-gcp.md

* Update using-external-dns-on-gcp.md
@RichieEscarez
site index for fluentd folder (knative#839)
f647be3
@RichieEscarez
add Hugo index files and frontmatter (knative#840)
fcf7d10
@RichieEscarez
hugo build files for autogen refdocs (knative#841)
c6ff268
@RichieEscarez
move resources and readme (knative#843)
16308a8
@RichieEscarez
site: add blog (knative#837)
2fb4b69 
* add blog folder

* switch to sentence case
@RichieEscarez
site: add community and contributing (knative#836)
564e7ec 
* add _index.md files and front matter

* switch to sentance case caps

* fix weights

* Update community/samples/README.md

Co-Authored-By: RichieEscarez <[email protected]>
@RichieEscarez
site: restructure content into a "docs" directory (knative#842)
15cf63b 
* move content into a 'docs' directory

* inject additional 'docs' directory
@RichieEscarez
site: add build files and front matter to serving samples (knative#850)
c0413e7 
* new _index.md files and front matter

* serving samples + fix urls

* remove file
@RichieEscarez
add PR#851 - channels (knative#853)
35f833c
@carieshmarie @RichieEscarez
Update README.md (knative#854)
5cfeca0
@samodell @RichieEscarez
Remove README.md from all links (knative#855)
adc6972 
* Remove README.md from all links

* mend

* mend

* mend
@RichieEscarez
update ref docs api build script and files (knative#997)
22c9bcf
@RichieEscarez
all links must have ./ (knative#1004)
787b89b 
* all links must have ./

* Update contributing/README.md

Co-Authored-By: RichieEscarez <[email protected]>

* Update contributing/README.md

Co-Authored-By: RichieEscarez <[email protected]>

* Update for clarity

* Update README.md

Fixing my poorly formatting suggestion
@RichieEscarez
ref tool steps + script (knative#1008)
dc0ba42
@RichieEscarez
Incorporate edits from knative#1008 (knative#1010)
94fcd1b 
* Incorporate edits from knative#1008

* Add "contributor" info link
@RichieEscarez
page-by-page link check fixes (knative#1024)
e114a57
@RichieEscarez
update readmes - source and site versions
27ef769
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Mar 19, 2019
@samodell
Copy link
Contributor

/approved cancel

(which I think will prevent it from being automatically re-added by Prow?)

@RichieEscarez RichieEscarez mentioned this pull request Mar 19, 2019
Closed
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2019
@RichieEscarez RichieEscarez removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2019
@RichieEscarez
Copy link
Contributor Author

@samodell and @carieshmarie , this PR is ready for review and the changes show on the staging site
https://deploy-preview-12--knative.netlify.com/docs/ (see notes in the desc. above)

@samodell
Copy link
Contributor

Adding back a hold on this for tonight. We can get this merged in first thing tomorrow.

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2019
@samodell samodell mentioned this pull request Mar 20, 2019
Closed
7 tasks
@carieshmarie carieshmarie added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2019
@RichieEscarez RichieEscarez removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2019
@knative-prow-robot knative-prow-robot merged commit 3c04f86 into knative:master Mar 20, 2019
grayside added a commit to grayside/docs that referenced this pull request Mar 21, 2019
@grayside
Merge remote-tracking branch 'origin/master' into remove-port-from-he…
4997c32 
…llo-dockerfiles

* origin/master:
  fix images (knative#1044)
  retry deleting folder (knative#1042)
  build version of API docs for 0.4 (knative#1040)
  Merge website files into Master (knative#1025)
grayside added a commit to grayside/docs that referenced this pull request Mar 21, 2019
@grayside
Merge remote-tracking branch 'origin/master' into helloworld-php-buil…
88e9ed8 
…d-error

* origin/master:
  fix images (knative#1044)
  retry deleting folder (knative#1042)
  build version of API docs for 0.4 (knative#1040)
  Merge website files into Master (knative#1025)
grayside added a commit to grayside/docs that referenced this pull request Mar 21, 2019
@grayside
Merge remote-tracking branch 'origin/master' into hello-kotlin-pin-gr…
56c6cdd 
…adle

* origin/master:
  fix images (knative#1044)
  retry deleting folder (knative#1042)
  build version of API docs for 0.4 (knative#1040)
  Merge website files into Master (knative#1025)
@RichieEscarez RichieEscarez deleted the mergerelease03 branch April 12, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@samodell samodell Awaiting requested review from samodell

Assignees

@samodell samodell

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@RichieEscarez @knative-prow-robot @googlebot @samodell @carieshmarie @mattmoor